feat: duplicate selected/all saved objects UI #305

yubonluo · 2024-03-21T08:05:01Z

Description

duplicate selected/all saved objects UI

Screenshot

Testing the changes

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

…ject#53) * Add copy saved objects among workspaces functionality Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix bug Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix bug Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> # Conflicts: # src/core/server/saved_objects/routes/copy.ts # src/plugins/saved_objects_management/public/constants.ts # src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx

* fix typo Signed-off-by: yuye-aws <yuyezhu@amazon.com> * adjust copy modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * list workspace with write permission on copy modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add copy icon and move getcopyworkspaces function from copy_modal to saved_object table Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix duplicate error in public workspace and change copy to duplicate all in header Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bug fix: create saved objects in public workspace Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove unused import Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change validate schema Signed-off-by: yuye-aws <yuyezhu@amazon.com> * behavior subject bug fix for workspace plugin Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> # Conflicts: # src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap # src/core/server/saved_objects/permission_control/acl.test.ts # src/core/server/saved_objects/permission_control/client.ts # src/plugins/saved_objects_management/public/management_section/objects_table/components/copy_modal.tsx # src/plugins/workspace/server/plugin.ts # src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts

* hide import for application home page Signed-off-by: Hailong Cui <ihailong@amazon.com> * add workpspace into gotoApp link Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove special logic for management workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * variable name change and more UTs Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> # Conflicts: # src/plugins/saved_objects_management/public/management_section/objects_table/__snapshots__/saved_objects_table.test.tsx.snap # src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/header.test.tsx.snap # src/plugins/saved_objects_management/public/management_section/objects_table/components/table.test.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/components/table.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx

* implement all duplicate copy modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add spacer after checkbox list Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add fail message for copy saved objects Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change title wording to manage library Signed-off-by: yuye-aws <yuyezhu@amazon.com> * single duplicate Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change wording Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove comment Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bug fix: keep selected saved objects info when cancel duplicate all Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix typo Signed-off-by: yuye-aws <yuyezhu@amazon.com> * use icu syntax in copy message Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bug fix: keep selected saved objects info when cancel duplicate single Signed-off-by: yuye-aws <yuyezhu@amazon.com> * set current workspace as the first option Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshot Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve conflict Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshot Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bug fix for saved object table Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshot Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove unused file Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change i18n constant Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove empty push Signed-off-by: yuye-aws <yuyezhu@amazon.com> * hide duplicate when workspace is disabled Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> # Conflicts: # src/plugins/saved_objects_management/public/constants.ts # src/plugins/saved_objects_management/public/management_section/objects_table/__snapshots__/saved_objects_table.test.tsx.snap # src/plugins/saved_objects_management/public/management_section/objects_table/components/copy_modal.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx # src/plugins/saved_objects_management/public/plugin.ts

* rename copy to duplicate Signed-off-by: yuye-aws <yuyezhu@amazon.com> * duplicate in visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * duplicate in dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve conflict Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update test and snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> * re-duplicate if some objects cannot be duplicated Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove clone for dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * rename duplicateState to duplicateMode Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change workspace prop to currentWorkspace in SavedObjectsDuplicateModal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change wording Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move duplicate modal to saved_objects for reuse Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move duplicate modal to saved objects management for reuse Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove minimal duplicate modal props logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor duplicate modal props for dashboard and visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Update getDuplicateWorkspaces function Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> * update function onDuplicate for dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Update doDuplicate for visualization Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> * refactor function getDuplicateWorkspaces Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add i18n context to saved objects table duplicate modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor duplicate modal logic in saved object table Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add error message for partial duplicate failed Signed-off-by: yuye-aws <yuyezhu@amazon.com> * merge commits Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add type info for dashboard and visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remote create vis reference logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Revert "remove clone for dashboard" This reverts commit 84f77fb. * hide duplicate when workspace disabled in dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * feat: skip permission validate when no workspaces and permissions attributes (opensearch-project#163) * feat: skip permission validate when saved object without workspaces and permissions attributes Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add annontation to skip permission check Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: remove bind and simplify validate logic Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: remove library write for object based ACL Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> * remove get workspaces with write permission logic and add readonly props to workspace attribute Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change type definition logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Fix typo (opensearch-project#176) --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * remove exit workspace logic (opensearch-project#179) Signed-off-by: yuye-aws <yuyezhu@amazon.com> * rename copy to duplicate Signed-off-by: yuye-aws <yuyezhu@amazon.com> * duplicate in visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * duplicate in dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve conflict Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update test and snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> * re-duplicate if some objects cannot be duplicated Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove clone for dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * rename duplicateState to duplicateMode Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change workspace prop to currentWorkspace in SavedObjectsDuplicateModal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change wording Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move duplicate modal to saved_objects for reuse Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move duplicate modal to saved objects management for reuse Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove minimal duplicate modal props logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor duplicate modal props for dashboard and visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Update getDuplicateWorkspaces function Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> * update function onDuplicate for dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Update doDuplicate for visualization Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> * refactor function getDuplicateWorkspaces Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add i18n context to saved objects table duplicate modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor duplicate modal logic in saved object table Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add error message for partial duplicate failed Signed-off-by: yuye-aws <yuyezhu@amazon.com> * merge commits Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add type info for dashboard and visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remote create vis reference logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Revert "remove clone for dashboard" This reverts commit 84f77fb. * hide duplicate when workspace disabled in dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove get workspaces with write permission logic and add readonly props to workspace attribute Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change type definition logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * rename variable and function name Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change permission mode to get target workspaces when duplicate Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> Co-authored-by: Lin Wang <wonglam@amazon.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com> # Conflicts: # src/core/public/workspace/workspaces_service.ts # src/plugins/saved_objects_management/public/constants.ts # src/plugins/saved_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx # src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts

src/core/server/saved_objects/routes/index.ts

...ed_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx

.../saved_objects_management/public/management_section/objects_table/components/header.test.tsx

SuZhou-Joe · 2024-03-21T08:41:38Z

...jects_management/public/management_section/objects_table/components/show_duplicate_modal.tsx

+ * modal can still recover (e.g. the name of the saved object was already taken).
+ */
+
+export function showDuplicateModal(


This file is used for?

This file is used to reuse the duplicate logic in subsequent dashboard and visualize plugins.

If we need to show a modal, we can embed it as a React component. Why do we make it as a util?

The file has been deleted.

...lugins/saved_objects_management/public/management_section/objects_table/components/table.tsx

...ins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx

src/plugins/workspace/public/workspace_client.ts

codecov-commenter · 2024-03-22T07:57:36Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.09%. Comparing base (efe6254) to head (8114a6f).
Report is 2 commits behind head on workspace-pr-integr.

Additional details and impacted files

@@                   Coverage Diff                   @@
##           workspace-pr-integr     #305      +/-   ##
=======================================================
+ Coverage                67.05%   67.09%   +0.03%     
=======================================================
  Files                     3345     3349       +4     
  Lines                    65045    65156     +111     
  Branches                 10505    10525      +20     
=======================================================
+ Hits                     43617    43717     +100     
- Misses                   18849    18860      +11     
  Partials                  2579     2579

Flag	Coverage Δ
Linux_	`66.44% <100.00%> (+0.04%)`	⬆️
_1	`32.07% <5.04%> (-0.53%)`	⬇️
_2	`55.34% <ø> (-0.05%)`	⬇️
_3	`?`
_4	`35.37% <100.00%> (+0.22%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: yubonluo <yubonluo@amazon.com>

…Dashboards into pr-integr-duplicate

Signed-off-by: yubonluo <yubonluo@amazon.com>

gaobinlong · 2024-03-28T06:20:37Z

src/core/server/saved_objects/routes/copy.ts

+ * this file be licensed under the Apache-2.0 license or a
+ * compatible open source license.
+ *
+ * Any modifications Copyright OpenSearch Contributors. See


The code in copy.ts and copy.test.ts are old, please use the code in the workspace-pr-integr branch.

Have reverted these codes

Signed-off-by: yubonluo <yubonluo@amazon.com>

SuZhou-Joe · 2024-04-02T05:33:12Z

src/plugins/saved_objects_management/public/lib/duplicate_saved_objects.ts

+/*
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * The OpenSearch Contributors require contributions made to
+ * this file be licensed under the Apache-2.0 license or a
+ * compatible open source license.
+ *
+ * Any modifications Copyright OpenSearch Contributors. See
+ * GitHub history for details.
+ */


Suggested change

/*

* SPDX-License-Identifier: Apache-2.0

*

* The OpenSearch Contributors require contributions made to

* this file be licensed under the Apache-2.0 license or a

* compatible open source license.

*

* Any modifications Copyright OpenSearch Contributors. See

* GitHub history for details.

*/

/*

* Copyright OpenSearch Contributors

* SPDX-License-Identifier: Apache-2.0

*/

SuZhou-Joe · 2024-04-02T05:37:38Z

...ed_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx

+    if (duplicateMode === DuplicateMode.All) {
+      selectedObjects = selectedObjects.filter((item) => this.isSavedObjectTypeIncluded(item.type));
+    }
+    // If the target workspace is selected, all saved objects will be retained.


Suggested change

// If the target workspace is selected, all saved objects will be retained.

// If the target workspace is not selected, all saved objects will be retained.

Should be not selected?

Have modified it according to your suggestion.

SuZhou-Joe · 2024-04-02T05:39:21Z

...ed_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx

+          >
+            <>
+              <EuiText size="s" color="subdued">
+                {


It seems the text is not wrapped by i18n

SuZhou-Joe · 2024-04-02T05:45:35Z

...ed_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx

400 lines are a too large for a single component, can we split it?
Some recommendations:

Move enum or types to separate files.

Split some render logic into a small Component. -> renderDuplicateObjectCategory renderDuplicateObjectCategories.

Consider to move some data transform function to util.

The code has been split to two files.

The enum file has been moved to types.ts;

The renderDuplicateObjectCategory and renderDuplicateObjectCategories function has been moved to a new tsx file.

SuZhou-Joe · 2024-04-02T05:46:18Z

.../saved_objects_management/public/management_section/objects_table/components/header.test.tsx

@@ -31,19 +31,59 @@
 import React from 'react';
 import { shallow } from 'enzyme';
 import { Header } from './header';
+import { any } from 'bluebird';


Suggested change

import { any } from 'bluebird';

Have modified it according to your suggestion.

SuZhou-Joe · 2024-04-02T06:17:14Z

...ins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx

-    const newIndexPatternUrl = applications.getUrlForApp('management', {
-      path: 'opensearch-dashboards/indexPatterns',
-    });
+    const newIndexPatternUrl = applications.getUrlForApp('indexPatterns');


Suggested change

const newIndexPatternUrl = applications.getUrlForApp('indexPatterns');

const newIndexPatternUrl = applications.getUrlForApp('management', {

path: 'opensearch-dashboards/indexPatterns',

});

Please do not change the index pattern url in this PR.

Have modified it according to your suggestion.

SuZhou-Joe · 2024-04-02T06:19:49Z

...ins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx

-import { DataPublicPluginStart } from '../../../../../plugins/data/public';
+import { Header, Table, Flyout, Relationships, SavedObjectsDuplicateModal } from './components';
+import { DataPublicPluginStart } from '../../../../data/public';
+


Suggested change

Have modified it according to your suggestion.

SuZhou-Joe · 2024-04-02T06:21:28Z

...ins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx

+import { Header, Table, Flyout, Relationships, SavedObjectsDuplicateModal } from './components';
+import { DataPublicPluginStart } from '../../../../data/public';
+
+import { DuplicateMode } from './';


Should import from ./components instead of ./index. Import from ./index makes the dependency chain confusing.

SuZhou-Joe · 2024-04-02T06:22:13Z

...aved_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx

+    jest.clearAllMocks();
+    jest.resetModules();


I am thinking maybe we should only clear the needed mocks instead of clearAll.

It seems that we don't any afterEach code.

Have deleted the logic

SuZhou-Joe · 2024-04-02T06:24:32Z

...lugins/saved_objects_management/public/management_section/objects_table/components/table.tsx

@@ -78,14 +80,15 @@ export interface TableProps {
  items: SavedObjectWithMetadata[];
  itemId: string | (() => string);
  totalItemCount: number;
-  onQueryChange: (query: any, filterFields: string[]) => void;
+  onQueryChange: (query: any, filterFields?: string[]) => void;


Seems unrelated changes.

Have deleted it according to your suggestion.

SuZhou-Joe · 2024-04-02T08:32:13Z

...ins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx

-import { Header, Table, Flyout, Relationships } from './components';
-import { DataPublicPluginStart } from '../../../../../plugins/data/public';
+import { Header, Table, Flyout, Relationships, SavedObjectsDuplicateModal } from './components';
+import { DataPublicPluginStart } from '../../../../data/public';


Suggested change

import { DataPublicPluginStart } from '../../../../data/public';

import { DataPublicPluginStart } from '../../../../plugins/data/public';

better to avoid unnecessary change.

Have modified it according to your suggestion.

Signed-off-by: yubonluo <yubonluo@amazon.com>

SuZhou-Joe

Looks much better than the first version, good job!

SuZhou-Joe · 2024-04-07T07:49:22Z

.../saved_objects_management/public/management_section/objects_table/components/header.test.tsx

@@ -38,12 +38,51 @@ describe('Header', () => {
      onExportAll: () => {},
      onImport: () => {},
      onRefresh: () => {},
-      totalCount: 4,
+      onDuplicate: () => {},
+      title: 'Saved Objects',


title is not a required props for header I think.

Have deleted the useless code.

SuZhou-Joe · 2024-04-07T07:58:11Z

...ed_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx

+    const targetWorkspaceId = targetWorkspaceOption?.at(0)?.key;
+    let selectedObjects = allSelectedObjects;
+    if (duplicateMode === DuplicateMode.All) {
+      selectedObjects = selectedObjects.filter((item) => this.isSavedObjectTypeIncluded(item.type));
+    }
+    // If the target workspace is not selected, all saved objects will be retained.
+    // If the target workspace has been selected, filter out the saved objects that belongs to the workspace.
+    const includedSelectedObjects = selectedObjects.filter((item) =>
+      !!targetWorkspaceId && !!item.workspaces ? !item.workspaces.includes(targetWorkspaceId) : true
+    );
+
+    const ignoredSelectedObjectsLength = selectedObjects.length - includedSelectedObjects.length;


Extract to a method of the component maybe? It is hard to understand what these lines are doing.

Sure, have extracted the logic to a method.

Signed-off-by: yubonluo <yubonluo@amazon.com>

…shboards into pr-integr-duplicate

Signed-off-by: yubonluo <yubonluo@amazon.com>

…shboards into pr-integr-duplicate

Signed-off-by: yubonluo <yubonluo@amazon.com>

SuZhou-Joe

LGTM

gaobinlong and others added 6 commits March 21, 2024 11:56

delete useless code

2a00d66

yubonluo requested a review from SuZhou-Joe as a code owner March 21, 2024 08:05

github-actions bot added the first-time-contributor label Mar 21, 2024

SuZhou-Joe reviewed Mar 21, 2024

View reviewed changes

refactor dupicate_model code and fix test error

f7c18b4

yubonluo and others added 6 commits March 26, 2024 10:15

add duplicate all/selected saved objects unit test

2be9d0c

Merge branch 'workspace-pr-integr' into pr-integr-duplicate

3294e6c

add util and copy unit test

49c6134

Signed-off-by: yubonluo <yubonluo@amazon.com>

Merge branch 'pr-integr-duplicate' of github.com:yubonluo/OpenSearch-…

c127a79

…Dashboards into pr-integr-duplicate

fix bug

cf1a8ac

Signed-off-by: yubonluo <yubonluo@amazon.com>

fix unit test error

c3f0ce6

Signed-off-by: yubonluo <yubonluo@amazon.com>

gaobinlong reviewed Mar 28, 2024

View reviewed changes

yubonluo added 4 commits March 28, 2024 15:14

add all unit test and fix code error

c0f62aa

Signed-off-by: yubonluo <yubonluo@amazon.com>

revert useless modifications

4d5af83

Signed-off-by: yubonluo <yubonluo@amazon.com>

add snapshot code

eddc611

Signed-off-by: yubonluo <yubonluo@amazon.com>

delete useless code

8114a6f

Signed-off-by: yubonluo <yubonluo@amazon.com>

SuZhou-Joe reviewed Apr 2, 2024

View reviewed changes

yubonluo added 2 commits April 3, 2024 16:49

optimize code

997d1b7

Signed-off-by: yubonluo <yubonluo@amazon.com>

split duplicate_modal

1cd26a3

Signed-off-by: yubonluo <yubonluo@amazon.com>

SuZhou-Joe approved these changes Apr 7, 2024

View reviewed changes

yubonluo added 2 commits April 7, 2024 16:43

optimize code

334129a

Signed-off-by: yubonluo <yubonluo@amazon.com>

Merge branch 'workspace-pr-integr' of github.com:ruanyl/OpenSearch-Da…

6b382e6

…shboards into pr-integr-duplicate

yubonluo added 7 commits April 7, 2024 17:31

fix unit test

c4ef126

Signed-off-by: yubonluo <yubonluo@amazon.com>

optimize code

33bffaf

Signed-off-by: yubonluo <yubonluo@amazon.com>

Merge branch 'workspace-pr-integr' of github.com:ruanyl/OpenSearch-Da…

98bfa54

…shboards into pr-integr-duplicate

Fixed the bug that can not duplicate all saved objects

e62431f

Signed-off-by: yubonluo <yubonluo@amazon.com>

Fixed the bug that can not duplicate all saved objects

a44deab

Signed-off-by: yubonluo <yubonluo@amazon.com>

optimize code

3c374f6

Signed-off-by: yubonluo <yubonluo@amazon.com>

delete useless code

d873930

Signed-off-by: yubonluo <yubonluo@amazon.com>

SuZhou-Joe approved these changes Apr 16, 2024

View reviewed changes

SuZhou-Joe merged commit 1a353cc into ruanyl:workspace-pr-integr Apr 16, 2024
43 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: duplicate selected/all saved objects UI #305

feat: duplicate selected/all saved objects UI #305

yubonluo commented Mar 21, 2024 •

edited

Loading

SuZhou-Joe Mar 21, 2024

yubonluo Mar 22, 2024

SuZhou-Joe Apr 2, 2024

yubonluo Apr 3, 2024

codecov-commenter commented Mar 22, 2024 •

edited

Loading

gaobinlong Mar 28, 2024

yubonluo Mar 28, 2024

SuZhou-Joe Apr 2, 2024

yubonluo Apr 3, 2024

SuZhou-Joe Apr 2, 2024

yubonluo Apr 3, 2024

SuZhou-Joe Apr 2, 2024

SuZhou-Joe Apr 2, 2024

yubonluo Apr 7, 2024

SuZhou-Joe Apr 2, 2024

yubonluo Apr 3, 2024

SuZhou-Joe Apr 2, 2024

yubonluo Apr 3, 2024

SuZhou-Joe Apr 2, 2024

yubonluo Apr 3, 2024

SuZhou-Joe Apr 2, 2024

SuZhou-Joe Apr 2, 2024

yubonluo Apr 3, 2024

yubonluo Apr 3, 2024

SuZhou-Joe Apr 2, 2024

yubonluo Apr 3, 2024

SuZhou-Joe Apr 2, 2024

yubonluo Apr 3, 2024

SuZhou-Joe left a comment

SuZhou-Joe Apr 7, 2024

yubonluo Apr 7, 2024

SuZhou-Joe Apr 7, 2024

yubonluo Apr 7, 2024

SuZhou-Joe left a comment

	// If the target workspace is selected, all saved objects will be retained.
	// If the target workspace is not selected, all saved objects will be retained.

	import { DataPublicPluginStart } from '../../../../data/public';
	import { DataPublicPluginStart } from '../../../../plugins/data/public';

feat: duplicate selected/all saved objects UI #305

feat: duplicate selected/all saved objects UI #305

Conversation

yubonluo commented Mar 21, 2024 • edited Loading

Description

Screenshot

Testing the changes

Check List

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Mar 22, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SuZhou-Joe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SuZhou-Joe left a comment

Choose a reason for hiding this comment

yubonluo commented Mar 21, 2024 •

edited

Loading

codecov-commenter commented Mar 22, 2024 •

edited

Loading