Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rename] management plugin #148

Merged
merged 1 commit into from
Mar 11, 2021

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Mar 10, 2021

Signed-off-by: Kawika Avilla kavilla414@gmail.com

Issue #, if available:
#37

Description of changes:
Rename files and variables within plugins/management

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Copy link
Contributor

@mihirsoni mihirsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boktorbb boktorbb merged commit 2ae5278 into opensearch-project:dashboards Mar 11, 2021
@kavilla kavilla deleted the rename-mgmt branch March 18, 2021 08:01
kavilla referenced this pull request in kavilla/OpenSearch-Dashboards Mar 19, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla added a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
mihirsoni pushed a commit that referenced this pull request Mar 20, 2021
Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Hailong-am pushed a commit to Hailong-am/OpenSearch-Dashboards that referenced this pull request Sep 20, 2023
* rename copy to duplicate

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* duplicate in visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* duplicate in dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* resolve conflict

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* update test and snapshots

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* re-duplicate if some objects cannot be duplicated

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove clone for dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* rename duplicateState to duplicateMode

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change workspace prop to currentWorkspace in SavedObjectsDuplicateModal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change wording

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* move duplicate modal to saved_objects for reuse

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* move duplicate modal to saved objects management for reuse

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove minimal duplicate modal props logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* refactor duplicate modal props for dashboard and visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Update getDuplicateWorkspaces function

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>

* update function onDuplicate for dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Update doDuplicate for visualization

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>

* refactor function getDuplicateWorkspaces

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add i18n context to saved objects table duplicate modal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* refactor duplicate modal logic in saved object table

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add error message for partial duplicate failed

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* merge commits

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add type info for dashboard and visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remote create vis reference logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Revert "remove clone for dashboard"

This reverts commit 84f77fb.

* hide duplicate when workspace disabled in dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* feat: skip permission validate when no workspaces and permissions attributes (opensearch-project#163)

* feat: skip permission validate when saved object without workspaces and permissions attributes

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add annontation to skip permission check

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: remove bind and simplify validate logic

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: remove library write for object based ACL

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>

* remove get workspaces with write permission logic and add readonly props to workspace attribute

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change type definition logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Fix typo (opensearch-project#176)

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* remove exit workspace logic (opensearch-project#179)

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* rename copy to duplicate

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* duplicate in visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* duplicate in dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* resolve conflict

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* update test and snapshots

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* re-duplicate if some objects cannot be duplicated

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove clone for dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* rename duplicateState to duplicateMode

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change workspace prop to currentWorkspace in SavedObjectsDuplicateModal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change wording

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* move duplicate modal to saved_objects for reuse

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* move duplicate modal to saved objects management for reuse

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove minimal duplicate modal props logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* refactor duplicate modal props for dashboard and visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Update getDuplicateWorkspaces function

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>

* update function onDuplicate for dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Update doDuplicate for visualization

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>

* refactor function getDuplicateWorkspaces

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add i18n context to saved objects table duplicate modal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* refactor duplicate modal logic in saved object table

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add error message for partial duplicate failed

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* merge commits

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add type info for dashboard and visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remote create vis reference logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Revert "remove clone for dashboard"

This reverts commit 84f77fb.

* hide duplicate when workspace disabled in dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove get workspaces with write permission logic and add readonly props to workspace attribute

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change type definition logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* rename variable and function name

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change permission mode to get target workspaces when duplicate

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

---------

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
Co-authored-by: Lin Wang <wonglam@amazon.com>
Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
yubonluo pushed a commit to yubonluo/OpenSearch-Dashboards that referenced this pull request Mar 21, 2024
* rename copy to duplicate

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* duplicate in visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* duplicate in dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* resolve conflict

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* update test and snapshots

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* re-duplicate if some objects cannot be duplicated

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove clone for dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* rename duplicateState to duplicateMode

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change workspace prop to currentWorkspace in SavedObjectsDuplicateModal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change wording

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* move duplicate modal to saved_objects for reuse

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* move duplicate modal to saved objects management for reuse

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove minimal duplicate modal props logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* refactor duplicate modal props for dashboard and visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Update getDuplicateWorkspaces function

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>

* update function onDuplicate for dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Update doDuplicate for visualization

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>

* refactor function getDuplicateWorkspaces

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add i18n context to saved objects table duplicate modal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* refactor duplicate modal logic in saved object table

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add error message for partial duplicate failed

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* merge commits

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add type info for dashboard and visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remote create vis reference logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Revert "remove clone for dashboard"

This reverts commit 84f77fb.

* hide duplicate when workspace disabled in dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* feat: skip permission validate when no workspaces and permissions attributes (opensearch-project#163)

* feat: skip permission validate when saved object without workspaces and permissions attributes

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add annontation to skip permission check

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: remove bind and simplify validate logic

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: remove library write for object based ACL

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>

* remove get workspaces with write permission logic and add readonly props to workspace attribute

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change type definition logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Fix typo (opensearch-project#176)

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* remove exit workspace logic (opensearch-project#179)

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* rename copy to duplicate

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* duplicate in visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* duplicate in dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* resolve conflict

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* update test and snapshots

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* re-duplicate if some objects cannot be duplicated

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove clone for dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* rename duplicateState to duplicateMode

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change workspace prop to currentWorkspace in SavedObjectsDuplicateModal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change wording

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* move duplicate modal to saved_objects for reuse

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* move duplicate modal to saved objects management for reuse

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove minimal duplicate modal props logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* refactor duplicate modal props for dashboard and visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Update getDuplicateWorkspaces function

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>

* update function onDuplicate for dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Update doDuplicate for visualization

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>

* refactor function getDuplicateWorkspaces

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add i18n context to saved objects table duplicate modal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* refactor duplicate modal logic in saved object table

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add error message for partial duplicate failed

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* merge commits

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add type info for dashboard and visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remote create vis reference logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Revert "remove clone for dashboard"

This reverts commit 84f77fb.

* hide duplicate when workspace disabled in dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove get workspaces with write permission logic and add readonly props to workspace attribute

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change type definition logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* rename variable and function name

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change permission mode to get target workspaces when duplicate

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

---------

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
Co-authored-by: Lin Wang <wonglam@amazon.com>
Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
# Conflicts:
#	src/core/public/workspace/workspaces_service.ts
#	src/plugins/saved_objects_management/public/constants.ts
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
#	src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Apr 16, 2024
* Add copy saved objects among workspaces functionality (opensearch-project#53)

* Add copy saved objects among workspaces functionality

Signed-off-by: gaobinlong <gbinlong@amazon.com>

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Fix bug

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Fix bug

Signed-off-by: gaobinlong <gbinlong@amazon.com>

---------

Signed-off-by: gaobinlong <gbinlong@amazon.com>
# Conflicts:
#	src/core/server/saved_objects/routes/copy.ts
#	src/plugins/saved_objects_management/public/constants.ts
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx

* feat: duplicate selected objects (opensearch-project#113)

* fix typo

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* adjust copy modal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* list workspace with write permission on copy modal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add copy icon and move getcopyworkspaces function from copy_modal to saved_object table

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* fix duplicate error in public workspace and change copy to duplicate all in header

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* bug fix: create saved objects in public workspace

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* update snapshots

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove unused import

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change validate schema

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* behavior subject bug fix for workspace plugin

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

---------

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
# Conflicts:
#	src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap
#	src/core/server/saved_objects/permission_control/acl.test.ts
#	src/core/server/saved_objects/permission_control/client.ts
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/copy_modal.tsx
#	src/plugins/workspace/server/plugin.ts
#	src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts

* Saved objects page change (opensearch-project#123)

* hide import for application home page

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* add workpspace into gotoApp link

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* remove special logic for management workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* variable name change and more UTs

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
# Conflicts:
#	src/plugins/saved_objects_management/public/management_section/objects_table/__snapshots__/saved_objects_table.test.tsx.snap
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/header.test.tsx.snap
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/table.test.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/table.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx

* feat: duplicate all and single objects (opensearch-project#121)

* implement all duplicate copy modal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add spacer after checkbox list

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add fail message for copy saved objects

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change title wording to manage library

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* single duplicate

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change wording

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove comment

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* bug fix: keep selected saved objects info when cancel duplicate all

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* fix typo

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* use icu syntax in copy message

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* bug fix: keep selected saved objects info when cancel duplicate single

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* set current workspace as the first option

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* update snapshot

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* resolve conflict

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* update snapshot

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* bug fix for saved object table

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* update snapshot

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove unused file

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change i18n constant

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove empty push

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* hide duplicate when workspace is disabled

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* update snapshots

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

---------

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
# Conflicts:
#	src/plugins/saved_objects_management/public/constants.ts
#	src/plugins/saved_objects_management/public/management_section/objects_table/__snapshots__/saved_objects_table.test.tsx.snap
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/copy_modal.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
#	src/plugins/saved_objects_management/public/plugin.ts

* feat: Duplicate dashboard visualize (opensearch-project#148)

* rename copy to duplicate

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* duplicate in visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* duplicate in dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* resolve conflict

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* update test and snapshots

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* re-duplicate if some objects cannot be duplicated

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove clone for dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* rename duplicateState to duplicateMode

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change workspace prop to currentWorkspace in SavedObjectsDuplicateModal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change wording

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* move duplicate modal to saved_objects for reuse

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* move duplicate modal to saved objects management for reuse

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove minimal duplicate modal props logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* refactor duplicate modal props for dashboard and visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Update getDuplicateWorkspaces function

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>

* update function onDuplicate for dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Update doDuplicate for visualization

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>

* refactor function getDuplicateWorkspaces

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add i18n context to saved objects table duplicate modal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* refactor duplicate modal logic in saved object table

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add error message for partial duplicate failed

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* merge commits

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add type info for dashboard and visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remote create vis reference logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Revert "remove clone for dashboard"

This reverts commit 84f77fb.

* hide duplicate when workspace disabled in dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* feat: skip permission validate when no workspaces and permissions attributes (opensearch-project#163)

* feat: skip permission validate when saved object without workspaces and permissions attributes

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add annontation to skip permission check

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: remove bind and simplify validate logic

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: remove library write for object based ACL

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>

* remove get workspaces with write permission logic and add readonly props to workspace attribute

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change type definition logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Fix typo (opensearch-project#176)

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* remove exit workspace logic (opensearch-project#179)

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* rename copy to duplicate

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* duplicate in visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* duplicate in dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* resolve conflict

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* update test and snapshots

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* re-duplicate if some objects cannot be duplicated

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove clone for dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* rename duplicateState to duplicateMode

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change workspace prop to currentWorkspace in SavedObjectsDuplicateModal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change wording

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* move duplicate modal to saved_objects for reuse

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* move duplicate modal to saved objects management for reuse

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove minimal duplicate modal props logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* refactor duplicate modal props for dashboard and visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Update getDuplicateWorkspaces function

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>

* update function onDuplicate for dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Update doDuplicate for visualization

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>

* refactor function getDuplicateWorkspaces

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add i18n context to saved objects table duplicate modal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* refactor duplicate modal logic in saved object table

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add error message for partial duplicate failed

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* merge commits

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add type info for dashboard and visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remote create vis reference logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Revert "remove clone for dashboard"

This reverts commit 84f77fb.

* hide duplicate when workspace disabled in dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove get workspaces with write permission logic and add readonly props to workspace attribute

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change type definition logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* rename variable and function name

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change permission mode to get target workspaces when duplicate

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

---------

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
Co-authored-by: Lin Wang <wonglam@amazon.com>
Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
# Conflicts:
#	src/core/public/workspace/workspaces_service.ts
#	src/plugins/saved_objects_management/public/constants.ts
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
#	src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts

* delete useless code

* refactor dupicate_model code and fix test error

* add duplicate all/selected saved objects unit test

* add util and copy unit test

Signed-off-by: yubonluo <yubonluo@amazon.com>

* fix bug

Signed-off-by: yubonluo <yubonluo@amazon.com>

* fix unit test error

Signed-off-by: yubonluo <yubonluo@amazon.com>

* add all unit test and fix code error

Signed-off-by: yubonluo <yubonluo@amazon.com>

* revert useless modifications

Signed-off-by: yubonluo <yubonluo@amazon.com>

* add snapshot code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* delete useless code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* optimize code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* split duplicate_modal

Signed-off-by: yubonluo <yubonluo@amazon.com>

* optimize code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* fix unit test

Signed-off-by: yubonluo <yubonluo@amazon.com>

* optimize code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Fixed the bug that can not duplicate all saved objects

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Fixed the bug that can not duplicate all saved objects

Signed-off-by: yubonluo <yubonluo@amazon.com>

* optimize code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* delete useless code

Signed-off-by: yubonluo <yubonluo@amazon.com>

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: gaobinlong <gbl_long@163.com>
Co-authored-by: Yuye Zhu <yuyezhu@amazon.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
raintygao pushed a commit to raintygao/OpenSearch-Dashboards that referenced this pull request Apr 19, 2024
* Add copy saved objects among workspaces functionality (opensearch-project#53)

* Add copy saved objects among workspaces functionality

Signed-off-by: gaobinlong <gbinlong@amazon.com>

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Fix bug

Signed-off-by: gaobinlong <gbinlong@amazon.com>

* Fix bug

Signed-off-by: gaobinlong <gbinlong@amazon.com>

---------

Signed-off-by: gaobinlong <gbinlong@amazon.com>
# Conflicts:
#	src/core/server/saved_objects/routes/copy.ts
#	src/plugins/saved_objects_management/public/constants.ts
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx

* feat: duplicate selected objects (opensearch-project#113)

* fix typo

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* adjust copy modal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* list workspace with write permission on copy modal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add copy icon and move getcopyworkspaces function from copy_modal to saved_object table

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* fix duplicate error in public workspace and change copy to duplicate all in header

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* bug fix: create saved objects in public workspace

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* update snapshots

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove unused import

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change validate schema

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* behavior subject bug fix for workspace plugin

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

---------

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
# Conflicts:
#	src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap
#	src/core/server/saved_objects/permission_control/acl.test.ts
#	src/core/server/saved_objects/permission_control/client.ts
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/copy_modal.tsx
#	src/plugins/workspace/server/plugin.ts
#	src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts

* Saved objects page change (opensearch-project#123)

* hide import for application home page

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* add workpspace into gotoApp link

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* remove special logic for management workspace

Signed-off-by: Hailong Cui <ihailong@amazon.com>

* variable name change and more UTs

Signed-off-by: Hailong Cui <ihailong@amazon.com>

---------

Signed-off-by: Hailong Cui <ihailong@amazon.com>
# Conflicts:
#	src/plugins/saved_objects_management/public/management_section/objects_table/__snapshots__/saved_objects_table.test.tsx.snap
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/header.test.tsx.snap
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/table.test.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/table.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx

* feat: duplicate all and single objects (opensearch-project#121)

* implement all duplicate copy modal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add spacer after checkbox list

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add fail message for copy saved objects

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change title wording to manage library

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* single duplicate

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change wording

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove comment

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* bug fix: keep selected saved objects info when cancel duplicate all

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* fix typo

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* use icu syntax in copy message

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* bug fix: keep selected saved objects info when cancel duplicate single

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* set current workspace as the first option

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* update snapshot

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* resolve conflict

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* update snapshot

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* bug fix for saved object table

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* update snapshot

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove unused file

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change i18n constant

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove empty push

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* hide duplicate when workspace is disabled

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* update snapshots

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

---------

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
# Conflicts:
#	src/plugins/saved_objects_management/public/constants.ts
#	src/plugins/saved_objects_management/public/management_section/objects_table/__snapshots__/saved_objects_table.test.tsx.snap
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/copy_modal.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
#	src/plugins/saved_objects_management/public/plugin.ts

* feat: Duplicate dashboard visualize (opensearch-project#148)

* rename copy to duplicate

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* duplicate in visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* duplicate in dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* resolve conflict

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* update test and snapshots

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* re-duplicate if some objects cannot be duplicated

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove clone for dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* rename duplicateState to duplicateMode

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change workspace prop to currentWorkspace in SavedObjectsDuplicateModal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change wording

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* move duplicate modal to saved_objects for reuse

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* move duplicate modal to saved objects management for reuse

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove minimal duplicate modal props logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* refactor duplicate modal props for dashboard and visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Update getDuplicateWorkspaces function

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>

* update function onDuplicate for dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Update doDuplicate for visualization

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>

* refactor function getDuplicateWorkspaces

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add i18n context to saved objects table duplicate modal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* refactor duplicate modal logic in saved object table

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add error message for partial duplicate failed

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* merge commits

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add type info for dashboard and visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remote create vis reference logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Revert "remove clone for dashboard"

This reverts commit 84f77fb.

* hide duplicate when workspace disabled in dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* feat: skip permission validate when no workspaces and permissions attributes (opensearch-project#163)

* feat: skip permission validate when saved object without workspaces and permissions attributes

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: add annontation to skip permission check

Signed-off-by: Lin Wang <wonglam@amazon.com>

* refactor: remove bind and simplify validate logic

Signed-off-by: Lin Wang <wonglam@amazon.com>

* feat: remove library write for object based ACL

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>

* remove get workspaces with write permission logic and add readonly props to workspace attribute

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change type definition logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Fix typo (opensearch-project#176)

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>

* remove exit workspace logic (opensearch-project#179)

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* rename copy to duplicate

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* duplicate in visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* duplicate in dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* resolve conflict

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* update test and snapshots

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* re-duplicate if some objects cannot be duplicated

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove clone for dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* rename duplicateState to duplicateMode

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change workspace prop to currentWorkspace in SavedObjectsDuplicateModal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change wording

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* move duplicate modal to saved_objects for reuse

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* move duplicate modal to saved objects management for reuse

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove minimal duplicate modal props logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* refactor duplicate modal props for dashboard and visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Update getDuplicateWorkspaces function

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>

* update function onDuplicate for dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Update doDuplicate for visualization

Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>

* refactor function getDuplicateWorkspaces

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add i18n context to saved objects table duplicate modal

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* refactor duplicate modal logic in saved object table

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add error message for partial duplicate failed

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* merge commits

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* add type info for dashboard and visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remote create vis reference logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Revert "remove clone for dashboard"

This reverts commit 84f77fb.

* hide duplicate when workspace disabled in dashboard

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* remove get workspaces with write permission logic and add readonly props to workspace attribute

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change type definition logic

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* rename variable and function name

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* change permission mode to get target workspaces when duplicate

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

---------

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Co-authored-by: Yulong Ruan <ruanyu1@gmail.com>
Co-authored-by: Lin Wang <wonglam@amazon.com>
Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
# Conflicts:
#	src/core/public/workspace/workspaces_service.ts
#	src/plugins/saved_objects_management/public/constants.ts
#	src/plugins/saved_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx
#	src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
#	src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts

* delete useless code

* refactor dupicate_model code and fix test error

* add duplicate all/selected saved objects unit test

* add util and copy unit test

Signed-off-by: yubonluo <yubonluo@amazon.com>

* fix bug

Signed-off-by: yubonluo <yubonluo@amazon.com>

* fix unit test error

Signed-off-by: yubonluo <yubonluo@amazon.com>

* add all unit test and fix code error

Signed-off-by: yubonluo <yubonluo@amazon.com>

* revert useless modifications

Signed-off-by: yubonluo <yubonluo@amazon.com>

* add snapshot code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* delete useless code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* optimize code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* split duplicate_modal

Signed-off-by: yubonluo <yubonluo@amazon.com>

* optimize code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* fix unit test

Signed-off-by: yubonluo <yubonluo@amazon.com>

* optimize code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Fixed the bug that can not duplicate all saved objects

Signed-off-by: yubonluo <yubonluo@amazon.com>

* Fixed the bug that can not duplicate all saved objects

Signed-off-by: yubonluo <yubonluo@amazon.com>

* optimize code

Signed-off-by: yubonluo <yubonluo@amazon.com>

* delete useless code

Signed-off-by: yubonluo <yubonluo@amazon.com>

---------

Signed-off-by: yubonluo <yubonluo@amazon.com>
Co-authored-by: gaobinlong <gbl_long@163.com>
Co-authored-by: Yuye Zhu <yuyezhu@amazon.com>
Co-authored-by: Hailong Cui <ihailong@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants