Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main to workspace #247

Merged
merged 121 commits into from
Feb 26, 2024
Merged

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Feb 21, 2024

Description

Merge main to workspace

The original file changes includes all main changes in past five months. The differences will be very large.
Here is the differences between the main branch:
https://github.com/opensearch-project/OpenSearch-Dashboards/compare/main...wanglam:OpenSearch-Dashboards:merge-main-to-workspace?expand=1

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-trigger-bot bot and others added 30 commits September 19, 2023 08:05
…-project#5042)

Signed-off-by: ananzh <ananzh@amazon.com>
(cherry picked from commit 329fa72)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…t#5065)

Signed-off-by: David Tippett <17506770+dtaivpp@users.noreply.github.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
…search-project#4882)

* Add reactflow with compiler fix

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Update CHANGELOG

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Update comment

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

* Revert adding reactflow dep

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>

---------

Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
* Update yarn install step from dev guide

Signed-off-by: Matt Provost <provomat@amazon.com>

* Update the corepack command

Signed-off-by: Matt Provost <provomat@amazon.com>

* Update to use corepack install

Signed-off-by: Matt Provost <provomat@amazon.com>

* Revise corepack url

Signed-off-by: Matt Provost <provomat@amazon.com>

---------

Signed-off-by: Matt Provost <provomat@amazon.com>
* Add Bandini as maintainer

Signed-off-by: Yan Zeng <zengyan@amazon.com>
…roject#5134)

Utilizing the GitHub `workflow_dispatch`, we can trigger
a job with a specific inputs.

By default, we run from this repo:
https://github.com/opensearch-project/opensearch-dashboards-functional-test

This workflow uses the target branch of the PR to pull down
from the FTRepo and run the tests from that specific branch.

For example, PRs against `main` will pull down `main` from
the FTRepo.

The problem occurs when new functionality is opened or a bug is
fixed and, per industry standard, we want to see tests added
to ensure functionality, stability, and raise the bar.

However, the cypress tests PR into the FTRepo depends on the new code
to be merged for the CI within the FTRepo to work. So we have a
stalemate that usually slows down PR review time.

Here, a manual run can be triggered by a maintainer. It will utilize
the source branch from the PR if provided.

Related to:
opensearch-project#4019

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Originally:
opensearch-project#5134

I believed it to be a good idea to ensure that triggering the CI
should always run a batch of tests. But I realized that some tests
can be added and just be bad tests until updated. Or if we want
to verify a flaky test in the CI.

So instead of only making it additional tests, the spec input will
complete replace the default tests (unless you append to the default).

Empty will run the default spec still. This will append on to the
PR comment with the spec that was run. So at least maintainers can
see it passed for a set of tests but it did not run the ones
we usually run.

Also adding some formatting for empty values for the PR comment.

Issue related:
opensearch-project#4019

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
* Basic working version of OSD without angular (opensearch-project#4982)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Data Explorer][Discover 2.0] Implement saved search embeddable (opensearch-project#5081)

* [Data Explorer][Discover 2.0] Implement saved search embeddable

Issue Resolve
opensearch-project#4233

---------

Signed-off-by: ananzh <ananzh@amazon.com>

* Deangular: removes angular paginate, cleanup data plugin and tilemap (opensearch-project#5060)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Data Explorer] Delete legacy discover selenium tests (opensearch-project#5088)

* delete legacy discover functional tests

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* remove discover folder in config file

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Data Explorer][Discover][Function Test] Fix ciGroup4 (opensearch-project#5099)

* add data-render-complete and data-shared-item for test convenience
* change docTableFieldCount to dataGridTableCellCount to fetch data grid cell
* add methods in data grid service to reuse current massive selenium tests
* update tests

Issue Resolve
opensearch-project#5098
opensearch-project#5058

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* [Data Explorer][Discover][Functional Test] fix ciGroup 8 (opensearch-project#5104)

Update index pattern fetch method in discover page due to changing to EuiComboBox.

Issue Resolve
opensearch-project#5103

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Fix cigroup 1 with dataGridTable helper functions (opensearch-project#5105)

* fix1

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix 1

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix anchor test

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix cigroup1

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* address comments

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering (opensearch-project#5111)

* fix cigroup3

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix error

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add data-shared-item tag (opensearch-project#5119)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Modifying html tests to utilize jsx and fixing tests to include all pluginPaths (opensearch-project#5080)

Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>

* fix cigroup6 (opensearch-project#5125)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Discover] Search on load fix (opensearch-project#5112)

* fixes search on load

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Fixes search after initial page load

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Data Explorer][Discover][Functional Test] Fix ciGroup7 (opensearch-project#5131)

* [Data Explorer][Discover][Functional Test] Fix ciGroup7

Issue Resolve
opensearch-project#5129

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* restore _discover_navigation

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Deangular: removes angular from notify and utils of opendashboards legacy (opensearch-project#5085)

* Basic working version of OSD without angular (opensearch-project#4982)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* deangularized notify and utils folders in the opendashboards legacy directory

Signed-off-by: Cameron Reed <chyltonreed@gmail.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Cameron Reed <chyltonreed@gmail.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Cameron Reed <chyltonreed@gmail.com>

* [Discover] Misc fixes (opensearch-project#5114)

* Canvas scrolling fix, remove notice and improve flyout focus

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Hide action icons unless hovered or focussed on

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* followup fixes from opensearch-project#5085

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>
Signed-off-by: Cameron Reed <chyltonreed@gmail.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Co-authored-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>
Co-authored-by: Cameron Reed <cameron.reed@oracle.com>
Co-authored-by: Cameron Reed <chyltonreed@gmail.com>
…h-project#5172)

Set env variable of NODE_OPTIONS for OSD to reference on startup
to ensure stable env.

Disable threshold enabled for disk allocation

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Matt Provost <provomat@amazon.com>
… `https://ip` in `opensearch.hosts` (opensearch-project#4949)

The `elasticsearch` client uses a flaws version that incorrectly sets `servername` on a `tls` connection using IPs.

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
…ject#5130)

* Improve testing of clients with long numerals support
* Work around serializer inheritance in the JS client

Signed-off-by: Miki <miki@amazon.com>
…o embeddable (opensearch-project#5160)

* all reload to force update embeddable
* add onQuerySubmit to top nav

Issue Resolve
opensearch-project#5116
opensearch-project#5159

Signed-off-by: ananzh <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
* Discover: Fixes state persistence after nav
* Fixed breadcrumbs and navigation
* fixes mobile view

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
…index pattern (opensearch-project#5171)

* [BUG][Data Explorer][Discover] Automatically load solo added default index pattern

This fix ensures that when add a default index pattern, Discover will
automatically select and load its details.

Issue Resolve
opensearch-project#5128

---------

Signed-off-by: ananzh <ananzh@amazon.com>
…sed on fetched data count (opensearch-project#5191)

* This PR adds a new rows state to the DiscoverCanvas component and updated it whenever
the data$ observable emitted new row data.
* The DiscoverTable component was then refactored to accept rows as a prop, making it
dependent on the parent component to provide the correct set of data. This ensures that the table
renders correctly based on the current data and doesn't rely on its internal state,
which could be outdated.

Issue Resolve
opensearch-project#5181

Signed-off-by: ananzh <ananzh@amazon.com>
opensearch-project#5134

Incorrectly uses the source of the code to pull down to BASE REF,
which would likely be `main` or `2.x`, etc.

It should be pulling down the PR branch. Cypress tests at the time
of merging were failing due to unrelated issue of disk allocation.

Not setting the env variables causes the workflow to rely on the default
values which is a return back to the original implementation and if the
env is set then it will be not empty.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
…fresh page or paste url to a new tab (opensearch-project#5206)

Issue Resolve
opensearch-project#5179
opensearch-project#5071

Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
* fix time conversion test bug
* Fix wrong test case

---------

Signed-off-by: Thanh <lechithanh2003@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Sean Neumann <1413295+seanneumann@users.noreply.github.com>
…e tests (opensearch-project#5221)

* remove angular-based view from DocViewsPlugin
* remove the test case that validates the display and content of the angular doc view

Issue Resolve
opensearch-project#5020

Signed-off-by: ananzh <ananzh@amazon.com>
* removed ftr test step from PR template

Signed-off-by: Leo Deng <leo7deng@gmail.com>

* change changelog

Signed-off-by: Leo Deng <leo7deng@gmail.com>

* Update CHANGELOG.md

Co-authored-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Leo Deng <105402895+Leo7Deng@users.noreply.github.com>

---------

Signed-off-by: Leo Deng <leo7deng@gmail.com>
Signed-off-by: Leo Deng <105402895+Leo7Deng@users.noreply.github.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
…ject#5167)

* initial commit for datasource

Signed-off-by: Eric <menwe@amazon.com>

* initial commit for datasource service

Signed-off-by: Eric <menwe@amazon.com>

* [Data Sources] Move datasource codebase from datasource plugin to data plugin

Signed-off-by: Eric <menwe@amazon.com>

* [Data Sources] Add datasource factory

Signed-off-by: Eric <menwe@amazon.com>

* datasource service

Signed-off-by: Eric <menwe@amazon.com>

* datasource with factory

Signed-off-by: Eric <menwe@amazon.com>

* datasource selector

Signed-off-by: Eric <menwe@amazon.com>

* exposes datasources from data plugin

Signed-off-by: Eric <menwe@amazon.com>

* index pattern datasource registration

Signed-off-by: Eric <menwe@amazon.com>

* add datasource selector to discover

Signed-off-by: Eric <menwe@amazon.com>

* remove unused files

Signed-off-by: Eric <menwe@amazon.com>

* add/exposes types for datasources as a set of services

Signed-off-by: Eric <menwe@amazon.com>

* add datasource selector unit tests

Signed-off-by: Eric <menwe@amazon.com>

* add metadata to selectable

Signed-off-by: Eric <menwe@amazon.com>

* redirection to observability for non-index-pattern datasource

Signed-off-by: Eric <menwe@amazon.com>

* add datasource factory tests

Signed-off-by: Eric <menwe@amazon.com>

* add datasource service test

Signed-off-by: Eric <menwe@amazon.com>

* datasources related fixes

Signed-off-by: Eric <menwe@amazon.com>

* add tests for datasource selectable

Signed-off-by: Eric <menwe@amazon.com>

* added types/interfaces for sidebar selector, and add a couple of enhancements

Signed-off-by: Eric <menwe@amazon.com>

* remove pill effect

Signed-off-by: Eric <menwe@amazon.com>

* change type for name display in selector for index patterns

Signed-off-by: Eric <menwe@amazon.com>

* remove legacy index selector

Signed-off-by: Eric <menwe@amazon.com>

* rename datasource change handler

Signed-off-by: Eric <menwe@amazon.com>

* remove unused constants

Signed-off-by: Eric <menwe@amazon.com>

* fix a redirection bug

Signed-off-by: Eric <menwe@amazon.com>

* add to change log

Signed-off-by: Eric <menwe@amazon.com>

* fix bg color issue in source selector

Signed-off-by: Eric <menwe@amazon.com>

* address oui and missing guard

Signed-off-by: Eric <menwe@amazon.com>

* add test subj

Signed-off-by: Eric <menwe@amazon.com>

* i18 and datasource interface default return

Signed-off-by: Eric <menwe@amazon.com>

* add default datasource tests

Signed-off-by: Eric <menwe@amazon.com>

* fix typo

Signed-off-by: Eric <menwe@amazon.com>

* modify wording

Signed-off-by: Eric <menwe@amazon.com>

* add experimental annotation to datasource

Signed-off-by: Eric <menwe@amazon.com>

* add type datasource filtering to remove type error hint

Signed-off-by: Eric <menwe@amazon.com>

* remove unused type

Signed-off-by: Eric <menwe@amazon.com>

* add 'type' to option type

Signed-off-by: Eric <menwe@amazon.com>

* Type fixes

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* cherry-pick type changes from remote and add partial fixes

Signed-off-by: Eric <menwe@amazon.com>

* add one type exports

Signed-off-by: Eric <menwe@amazon.com>

* remaining type errors fixed

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* addressing comments

Signed-off-by: Eric <menwe@amazon.com>

* address dedup

Signed-off-by: Eric <menwe@amazon.com>

* refactor datasource_selectable to address comments

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* remove unnecessary optional chaining

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* refactor variable names

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* move functnions out of selectable component

Signed-off-by: Eric <menwe@amazon.com>

* add comments for dedup/options list updates

Signed-off-by: Eric <menwe@amazon.com>

* add experimental annotation

Signed-off-by: Eric <menwe@amazon.com>

* callback and experimental annotation on types

Signed-off-by: Eric <menwe@amazon.com>

* handleSourceSelection callback

Signed-off-by: Eric <menwe@amazon.com>

* datasource annotation and import adjustment

Signed-off-by: Eric <menwe@amazon.com>

* remove pill effect

Signed-off-by: Eric <menwe@amazon.com>

* minor changes addressing latest comments

Signed-off-by: Eric <menwe@amazon.com>

* remove unused tests

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Josh Romero <rmerqg@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
mengweieric and others added 23 commits January 24, 2024 19:12
…nsearch-project#5719)

* sort datasource option list in each group alphabetically
* add test for sorting
* remove one datasource per test

---------

Signed-off-by: Eric <menwe@amazon.com>
* [Docs] Updates dev guide for security

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* better default creds

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* undo changelog changes

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Adds sample password

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
* [Discover] Fix 0 filters applied state

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Adds changelog

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* fixes unit test

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
…age when multiple datasource is enabled (opensearch-project#5756)

* add datasource picker as a component and use it in devtools and add sample data page

Signed-off-by: Lu Yu <nluyu@amazon.com>

* add changelog for 5756

Signed-off-by: Lu Yu <nluyu@amazon.com>

* wraps prepend with i18n and fix typo

Signed-off-by: Lu Yu <nluyu@amazon.com>

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
…opensearch-project#5675)

Add `--single-version` switch to `bootstrap` to manipulate the behavior of single-version validation

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
…a source is enabled (opensearch-project#5781)

* add datasource picker to saved object management page when multiple data source is enabled

Signed-off-by: Lu Yu <nluyu@amazon.com>

* add changelog

Signed-off-by: Lu Yu <nluyu@amazon.com>

* change name to cluster selector and move to higher level

Signed-off-by: Lu Yu <nluyu@amazon.com>

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
…fault cluster supported (opensearch-project#5751)

* datasource id is required if multiple datasource is enabled and no default cluster supported

Signed-off-by: Xinrui Bai <xinruiba@amazon.com>

---------

Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
…s from uploading files to have data source (opensearch-project#5777)

* update import api only

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* fix the local cluster 404 Not Found error and import.test integration 500 error

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* format import api

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* fix resolve import error api integration test failure

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* remove unused wait

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* update CHANGELOG for import api change

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* fix the bug when collect daved object

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* resolve comments

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* add more test

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* fix the failed test

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* fix the failed test

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* fix the bug when import create new with data source

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* update import api only

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* fix the local cluster 404 Not Found error and import.test integration 500 error

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* format import api

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* fix resolve import error api integration test failure

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* remove unused wait

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* update CHANGELOG for import api change

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* fix the bug when collect daved object

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* resolve comments

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* add more test

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Update CHANGELOG.md

will update

Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>

* Clean up post-rebase artifacts

Signed-off-by: Miki <miki@amazon.com>

* refactor the generate id logic

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* rename some test parameters

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* fix the bug that create new with data source conflict

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* fix the bug that create new with data source conflict

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* fix when first check conflict and auto override, the result are created new but display they are overriden

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* fix the overriden bug

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* refactor code

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* fix the overriden bug by refactoring check data source conflict

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* fix test

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* fix test

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* back to mainline yaml

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* remove local yaml change

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* add test

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* remove unused var

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* remove unused console log

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
Co-authored-by: Miki <miki@amazon.com>
* Support local cluster by default

Signed-off-by: Xinrui Bai <xinruiba@amazon.com>

* Update log file

Signed-off-by: Xinrui Bai <xinruiba@amazon.com>

* Skip changelog file updating

Signed-off-by: Xinrui Bai <xinruiba@amazon.com>

---------

Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
opensearch-project#5619)

* Fix (TableVis): Properly filter table columns when sending to filter event handler

Signed-off-by: Josh Romero <rmerqg@amazon.com>

* add changelog

Signed-off-by: Josh Romero <rmerqg@amazon.com>

---------

Signed-off-by: Josh Romero <rmerqg@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Bumping node version to 18.19.0. Updates .nvmrc.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
…pensearch-project#5789)

* basic table working

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* basic styling

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix header column style

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* correctly display optional col header actions

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* move col to the right or left if applicable

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add cell filter for and filter out buttons

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add cell action on doc table, half working on toggle columns

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* sorting

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Add toggling between legacy and new table

According to opensearch-project#5739, add toggle using storage.

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* get rid of the console log

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* optimize cell filter logics

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add more refactoring

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* remove an used line

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* some more table cell optimization

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Initial UI fixes (opensearch-project#5758)
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Table optimization with lazy loading (opensearch-project#5760)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Discover with Legacy Table] fix copy issue and open feedbacks in a new tab (opensearch-project#5761)

* add a colon (:) after the key
* ensure there's a space between each key-value pair
* allow feedback url to open in a new tab

Signed-off-by: Anan Z <ananzh@amazon.com>

* [Discover] Fix more UI (opensearch-project#5764)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Discover] Fixes table optimization (opensearch-project#5763)

* [Discover] Fixes table optimization

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* improved loader

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Change sort icon according to current sort conditions (opensearch-project#5772)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix breadcrumb navigation (opensearch-project#5773)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Add pagination to discover embeddable (opensearch-project#5770)

* Add pagination

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix an errir

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* small change

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix errors

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Discover] Prevent wrapping of time series cells (opensearch-project#5779)

Signed-off-by: Miki <miki@amazon.com>

* Vertically align the text in QueryStringInputUI with other elements on the page (opensearch-project#5780)

Signed-off-by: Miki <miki@amazon.com>

* Use `ouiCodeFont` in Discover and reduce text size (opensearch-project#5783)

Also:
* Fix react `key` errors
* vertically align source cells
* Clamp the height of the cells
* Make sure time-series column never grows

Signed-off-by: Miki <miki@amazon.com>

* [Discover] Display filter buttons at top right of the cell (opensearch-project#5784)

Signed-off-by: Miki <miki@amazon.com>

* [Discover] Vertically align the details toggle button (opensearch-project#5785)

Signed-off-by: Miki <miki@amazon.com>

* [Discover] Fix overflow of the expanded document (opensearch-project#5788)

* Fix vertical alignment of expand details button
Fix colspan of details cells

Signed-off-by: Miki <miki@amazon.com>

* Fix overflow problem of detailed doc

Signed-off-by: Miki <miki@amazon.com>

---------

Signed-off-by: Miki <miki@amazon.com>

* update feedback msg (opensearch-project#5787)

Signed-off-by: Anan Z <ananzh@amazon.com>

* Resolve sort, default sort and short dot (opensearch-project#5771)

Signed-off-by: Anan Z <ananzh@amazon.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* [Discover] Fixes pagination style (opensearch-project#5778)

* fixes pagination style

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* style-lint fix

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* fix react warning for unnecessary prop

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Show total hit count and pass services in embeddable

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* removed unnecessary div

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>

* add changelog

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix table column error

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Fix pagination edge case

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Routing for surrounding doc link should work without a question mark appending to the end (opensearch-project#5776)

* routing for surrounding doc should work without ?

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* change path to not include appstate

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* delete optional app state for single doc link too

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* type fixes (opensearch-project#5795)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Update toggle to button (opensearch-project#5808)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Adds support for line count (opensearch-project#5814)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Add swith to datagrid table and fix ciGroup1 (opensearch-project#5816)

* add swith to datagrid table and fix ciGroup1

Signed-off-by: Anan <ananzh@amazon.com>

* fix ciGroup7

Signed-off-by: Anan Z <ananzh@amazon.com>

* fix ciGroup6

Signed-off-by: Anan Z <ananzh@amazon.com>

---------

Signed-off-by: Anan <ananzh@amazon.com>
Signed-off-by: Anan Z <ananzh@amazon.com>

* add missing snapshot (opensearch-project#5818)

Signed-off-by: Anan Z <ananzh@amazon.com>

* fix pluign ftr tests (opensearch-project#5821)

Signed-off-by: Anan Z <ananzh@amazon.com>

* update snapshot (opensearch-project#5824)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Fix functional 3 and 4 for discover legacy (opensearch-project#5822)

* fix 3 and 4

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix functional 3 and 4

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* dashboard expect

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Solve cigroup 7 flakiness (opensearch-project#5826)

* test hover

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* comment out other ci to speed up

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* uncomment

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Discover] Simplify feedback modal (opensearch-project#5837)

* Simplify feedback modal

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* renames datagrid  settng to newDiscover setting

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* removes sub module from branch

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Persist line height (opensearch-project#5836)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Update table revert changelog (opensearch-project#5835)

* Update table revert changelog
### Description

updates changelog

### Issues Resolved

<!-- List any issues this PR will resolve. Prefix the issue with the keyword closes, fixes, fix -->
<!-- Example: closes opensearch-project#1234 or fixes <Issue_URL> -->

## Screenshot

<!-- Attach any relevant screenshots. Any change to the UI requires an attached screenshot in the PR Description -->

## Testing the changes

<!--
  Please provide detailed steps for validating your changes. This could involve specific commands to run,
  pages to visit, scenarios to try or any other information that would help reviewers verify
  the functionality of your change
-->

### Check List

- [ ] All tests pass
  - [ ] `yarn test:jest`
  - [ ] `yarn test:jest_integration`
- [ ] New functionality includes testing.
- [ ] New functionality has been documented.
- [ ] Update [CHANGELOG.md](./../CHANGELOG.md)
- [ ] Commits are signed per the DCO using --signoff

* revert dependency change

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* nit

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* update changelog

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* fix table height persist on context page

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Anan Z <ananzh@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Anan <ananzh@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Ganesh0107 <ganesh.gopal@freshworks.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
* bump oui to 1.5.1

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Updates changelog

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
…method from plug-in module (opensearch-project#5851)

* Adds method to register credential provider during data source plugin setup

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>

* Adds method to register authentication method with UI elements during data source management plugin setup

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>

* Adds UT for auth registry in data source plugin

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>

* Adds UT for auth registry in data source management plugin

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>

* Adds UT for data_source_management plugin.ts

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>

* Refactor code

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>

---------

Signed-off-by: Bandini Bhopi <bandinib@amazon.com>
* [LocalCluster] support in devtool and index pattern creation page

Signed-off-by: Xinrui Bai <xinruiba@amazon.com>

* [LocalCluster] support default cluster in home tutorial page

Signed-off-by: Xinrui Bai <xinruiba@amazon.com>

* [LocalCluster] support default cluster in object import page

Signed-off-by: Xinrui Bai <xinruiba@amazon.com>

---------

Signed-off-by: Xinrui Bai <xinruiba@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
…ting saved objects, after this fix, the first time import will display `new` and after that will display `overwritten` if import the same objects (opensearch-project#5871)

* bug fix 5861

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* clean unused parameters in test

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* bug fix 5861

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* clean unused parameters in test

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* fix failed UT

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* update CHANGELOG.md

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

* Update changelog message

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>

---------

Signed-off-by: yujin-emma <yujin.emma.work@gmail.com>
Signed-off-by: Yu Jin <112784385+yujin-emma@users.noreply.github.com>
…ypress tests within Dashboards repo (opensearch-project#5725)

 * Adds Github workflow which gets triggered on dispatch event sent from FT Repo Orchestrator. Currently this workflow defaults to using release bundle artifact for Opensearch and Dashboards. 
 * In this iteration, pulling out few of the dashboards sanity test from FT repo into the Dashboards repo -  https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/cypress/integration/common/dashboard_sample_data_spec.js
 * Introduces Cypress dependency into the package json to run cypress tests within repo. Currently, I'm pulling the version which matches the one in FT repo. 
 * Adds cypress config file.

ToDo:
Add fallback mechanism for using snapshot URL when release bundle url is not accessible.
Enable this workflow for each PR/push event.


### Issues Resolved
opensearch-project#5720

Signed-off-by: Manasvini B Suryanarayana <manasvis@amazon.com>
…source plugin (opensearch-project#5895)

* add api registry and allow it to be added into client config

Signed-off-by: Lu Yu <nluyu@amazon.com>

* add changelog

Signed-off-by: Lu Yu <nluyu@amazon.com>

* add documentation for multi data source plugin api registry

Signed-off-by: Lu Yu <nluyu@amazon.com>

* change to resolve promise before calling getQueryClient

Signed-off-by: Lu Yu <nluyu@amazon.com>

---------

Signed-off-by: Lu Yu <nluyu@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
@wanglam wanglam marked this pull request as ready for review February 22, 2024 01:37
Signed-off-by: Lin Wang <wonglam@amazon.com>
@ruanyl ruanyl merged commit fe9a4c1 into ruanyl:workspace Feb 26, 2024
4 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.