Deangular: removes angular from notify and utils of opendashboards legacy #5085

camreedOCI · 2023-09-21T19:57:01Z

Description

This PR makes the following changes:

Clean out src/plugins/opensearch_dashboards_legacy/public/notify:
Remove src/plugins/opensearch_dashboards_legacy/public/notify/lib/format_angular_http_error.ts
Remove src/plugins/opensearch_dashboards_legacy/public/notify/lib/add_fatal_error.ts
Clean src/plugins/opensearch_dashboards_legacy/public/notify/lib/index.ts

Clean out src/plugins/opensearch_dashboards_legacy/public/utils
Remove src/plugins/opensearch_dashboards_legacy/public/utils/system_api.ts
Remove src/plugins/opensearch_dashboards_legacy/public/utils/register_listen_event_listener.js
Remove src/plugins/opensearch_dashboards_legacy/public/utils/private.js Remove src/plugins/opensearch_dashboards_legacy/public/utils/private.d.ts
Remove src/plugins/opensearch_dashboards_legacy/public/utils/osd_accessible_click.js

Issues Resolved

Partly addresses #5019
The remainder is addressed in this PR

Screenshot

Testing the changes

Check List

ashwin-pc

@camreedOCI Thanks for the change. It looks mostly good to me, looks like a few changes that you did not intend to bring in were added since i updated the base of your branch. Can you fix these?

ashwin-pc · 2023-09-21T22:54:17Z

package.json

@@ -11,7 +11,7 @@
    "dashboarding"
  ],
  "private": true,
-  "version": "3.0.0",
+  "version": "2.9.0",


Can you revert this change? This shouldnt be modified.

ashwin-pc · 2023-09-21T22:56:31Z

...ugins/vis_type_tagcloud/public/components/__snapshots__/tag_cloud_visualization.test.js.snap

This diff seems unrelated to this change. Is there a reason o include this?

ashwin-pc · 2023-09-21T23:05:30Z

src/plugins/opensearch_dashboards_legacy/public/notify/lib/add_fatal_error.ts

Do we want to delete this file? Cant we simply mark this as deprecated and remove the angular specific usage?

i.e.

/** * Adds an error to the list of fatal errors. * @deprecated Use `core.fatalErrors.add` instead */ export function addFatalError( fatalErrors: FatalErrorsSetup, error: Error | string, location?: string ) { fatalErrors.add(error, location); }

ashwin-pc · 2023-09-21T23:09:17Z

src/plugins/opensearch_dashboards_legacy/public/utils/index.ts

If you are deleting all the exports from this file, feel free to delete this file as well.

ashwin-pc · 2023-09-21T23:09:56Z

src/plugins/opensearch_dashboards_legacy/public/index.ts

@@ -38,4 +38,4 @@ export * from './plugin';

 export { PaginateDirectiveProvider, PaginateControlsDirectiveProvider } from './paginate/paginate';
 export * from './notify';
-export * from './utils';
+// export * from './utils';


If you are deleing all the exports from utils, feel free to delete this commented line as well

codecov · 2023-09-21T23:15:05Z

Codecov Report

Merging #5085 (bc454ad) into feature/deangular (5fe2fae) will increase coverage by 0.07%.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##           feature/deangular    #5085      +/-   ##
=====================================================
+ Coverage              66.69%   66.76%   +0.07%     
=====================================================
  Files                   3283     3277       -6     
  Lines                  63059    62980      -79     
  Branches               10031    10027       -4     
=====================================================
- Hits                   42056    42048       -8     
+ Misses                 18537    18464      -73     
- Partials                2466     2468       +2

Flag	Coverage Δ
Linux_1	`?`
Linux_2	`55.23% <ø> (ø)`
Linux_3	`43.76% <ø> (+0.10%)`	⬆️
Linux_4	`35.43% <ø> (ø)`
Windows_1	`35.33% <ø> (+0.06%)`	⬆️
Windows_2	`55.20% <ø> (ø)`
Windows_3	`43.76% <ø> (+0.10%)`	⬆️
Windows_4	`35.43% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ugins/opensearch_dashboards_legacy/public/index.ts	`50.00% <ø> (ø)`

... and 2 files with indirect coverage changes

ashwin-pc

Thanks @camreedOCI! Your changes look good :) Looks like you accidentally deleted one export. I can add that back in a fast follow PR, unless you want to make the change yourself. Let me know.

ashwin-pc · 2023-09-22T21:25:56Z

src/plugins/opensearch_dashboards_legacy/public/notify/lib/index.ts

-  formatAngularHttpError,
-  AngularHttpError,
-} from './format_angular_http_error';
-export { addFatalError } from './add_fatal_error';


Looks like you accidentally deleted this too

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

…irectory Signed-off-by: Cameron Reed <chyltonreed@gmail.com>

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

ashwin-pc · 2023-09-28T03:47:00Z

Merged even though there are a few CI issues, #5114 fixes them

* Canvas scrolling fix, remove notice and improve flyout focus Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Hide action icons unless hovered or focussed on Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * followup fixes from #5085 Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Basic working version of OSD without angular (#4982) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Data Explorer][Discover 2.0] Implement saved search embeddable (#5081) * [Data Explorer][Discover 2.0] Implement saved search embeddable Issue Resolve #4233 --------- Signed-off-by: ananzh <ananzh@amazon.com> * Deangular: removes angular paginate, cleanup data plugin and tilemap (#5060) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Data Explorer] Delete legacy discover selenium tests (#5088) * delete legacy discover functional tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * remove discover folder in config file Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Data Explorer][Discover][Function Test] Fix ciGroup4 (#5099) * add data-render-complete and data-shared-item for test convenience * change docTableFieldCount to dataGridTableCellCount to fetch data grid cell * add methods in data grid service to reuse current massive selenium tests * update tests Issue Resolve #5098 #5058 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * [Data Explorer][Discover][Functional Test] fix ciGroup 8 (#5104) Update index pattern fetch method in discover page due to changing to EuiComboBox. Issue Resolve #5103 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Fix cigroup 1 with dataGridTable helper functions (#5105) * fix1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix 1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix anchor test Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix cigroup1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering (#5111) * fix cigroup3 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix error Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add data-shared-item tag (#5119) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Modifying html tests to utilize jsx and fixing tests to include all pluginPaths (#5080) Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> * fix cigroup6 (#5125) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover] Search on load fix (#5112) * fixes search on load Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fixes search after initial page load Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Data Explorer][Discover][Functional Test] Fix ciGroup7 (#5131) * [Data Explorer][Discover][Functional Test] Fix ciGroup7 Issue Resolve #5129 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * restore _discover_navigation Signed-off-by: Anan Zhuang <ananzh@amazon.com> --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Deangular: removes angular from notify and utils of opendashboards legacy (#5085) * Basic working version of OSD without angular (#4982) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * deangularized notify and utils folders in the opendashboards legacy directory Signed-off-by: Cameron Reed <chyltonreed@gmail.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Cameron Reed <chyltonreed@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Cameron Reed <chyltonreed@gmail.com> * [Discover] Misc fixes (#5114) * Canvas scrolling fix, remove notice and improve flyout focus Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Hide action icons unless hovered or focussed on Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * followup fixes from #5085 Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: ananzh <ananzh@amazon.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> Signed-off-by: Cameron Reed <chyltonreed@gmail.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Co-authored-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> Co-authored-by: Cameron Reed <cameron.reed@oracle.com> Co-authored-by: Cameron Reed <chyltonreed@gmail.com>

* Basic working version of OSD without angular (opensearch-project#4982) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Data Explorer][Discover 2.0] Implement saved search embeddable (opensearch-project#5081) * [Data Explorer][Discover 2.0] Implement saved search embeddable Issue Resolve opensearch-project#4233 --------- Signed-off-by: ananzh <ananzh@amazon.com> * Deangular: removes angular paginate, cleanup data plugin and tilemap (opensearch-project#5060) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Data Explorer] Delete legacy discover selenium tests (opensearch-project#5088) * delete legacy discover functional tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * remove discover folder in config file Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Data Explorer][Discover][Function Test] Fix ciGroup4 (opensearch-project#5099) * add data-render-complete and data-shared-item for test convenience * change docTableFieldCount to dataGridTableCellCount to fetch data grid cell * add methods in data grid service to reuse current massive selenium tests * update tests Issue Resolve opensearch-project#5098 opensearch-project#5058 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * [Data Explorer][Discover][Functional Test] fix ciGroup 8 (opensearch-project#5104) Update index pattern fetch method in discover page due to changing to EuiComboBox. Issue Resolve opensearch-project#5103 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Fix cigroup 1 with dataGridTable helper functions (opensearch-project#5105) * fix1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix 1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix anchor test Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix cigroup1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering (opensearch-project#5111) * fix cigroup3 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix error Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add data-shared-item tag (opensearch-project#5119) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Modifying html tests to utilize jsx and fixing tests to include all pluginPaths (opensearch-project#5080) Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> * fix cigroup6 (opensearch-project#5125) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover] Search on load fix (opensearch-project#5112) * fixes search on load Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fixes search after initial page load Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Data Explorer][Discover][Functional Test] Fix ciGroup7 (opensearch-project#5131) * [Data Explorer][Discover][Functional Test] Fix ciGroup7 Issue Resolve opensearch-project#5129 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * restore _discover_navigation Signed-off-by: Anan Zhuang <ananzh@amazon.com> --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Deangular: removes angular from notify and utils of opendashboards legacy (opensearch-project#5085) * Basic working version of OSD without angular (opensearch-project#4982) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * deangularized notify and utils folders in the opendashboards legacy directory Signed-off-by: Cameron Reed <chyltonreed@gmail.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Cameron Reed <chyltonreed@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Cameron Reed <chyltonreed@gmail.com> * [Discover] Misc fixes (opensearch-project#5114) * Canvas scrolling fix, remove notice and improve flyout focus Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Hide action icons unless hovered or focussed on Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * followup fixes from opensearch-project#5085 Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: ananzh <ananzh@amazon.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> Signed-off-by: Cameron Reed <chyltonreed@gmail.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Co-authored-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> Co-authored-by: Cameron Reed <cameron.reed@oracle.com> Co-authored-by: Cameron Reed <chyltonreed@gmail.com> (cherry picked from commit 0557ab1) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Deangular] OSD without angular (#5086) * Basic working version of OSD without angular (#4982) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Data Explorer][Discover 2.0] Implement saved search embeddable (#5081) * [Data Explorer][Discover 2.0] Implement saved search embeddable Issue Resolve #4233 --------- Signed-off-by: ananzh <ananzh@amazon.com> * Deangular: removes angular paginate, cleanup data plugin and tilemap (#5060) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Data Explorer] Delete legacy discover selenium tests (#5088) * delete legacy discover functional tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * remove discover folder in config file Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Data Explorer][Discover][Function Test] Fix ciGroup4 (#5099) * add data-render-complete and data-shared-item for test convenience * change docTableFieldCount to dataGridTableCellCount to fetch data grid cell * add methods in data grid service to reuse current massive selenium tests * update tests Issue Resolve #5098 #5058 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * [Data Explorer][Discover][Functional Test] fix ciGroup 8 (#5104) Update index pattern fetch method in discover page due to changing to EuiComboBox. Issue Resolve #5103 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Fix cigroup 1 with dataGridTable helper functions (#5105) * fix1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix 1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix anchor test Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix cigroup1 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * address comments Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering (#5111) * fix cigroup3 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix error Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add data-shared-item tag (#5119) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Modifying html tests to utilize jsx and fixing tests to include all pluginPaths (#5080) Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> * fix cigroup6 (#5125) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover] Search on load fix (#5112) * fixes search on load Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Fixes search after initial page load Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Data Explorer][Discover][Functional Test] Fix ciGroup7 (#5131) * [Data Explorer][Discover][Functional Test] Fix ciGroup7 Issue Resolve #5129 Signed-off-by: Anan Zhuang <ananzh@amazon.com> * restore _discover_navigation Signed-off-by: Anan Zhuang <ananzh@amazon.com> --------- Signed-off-by: Anan Zhuang <ananzh@amazon.com> * Deangular: removes angular from notify and utils of opendashboards legacy (#5085) * Basic working version of OSD without angular (#4982) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * deangularized notify and utils folders in the opendashboards legacy directory Signed-off-by: Cameron Reed <chyltonreed@gmail.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Cameron Reed <chyltonreed@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Cameron Reed <chyltonreed@gmail.com> * [Discover] Misc fixes (#5114) * Canvas scrolling fix, remove notice and improve flyout focus Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Hide action icons unless hovered or focussed on Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * followup fixes from #5085 Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: ananzh <ananzh@amazon.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> Signed-off-by: Cameron Reed <chyltonreed@gmail.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Co-authored-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> Co-authored-by: Cameron Reed <cameron.reed@oracle.com> Co-authored-by: Cameron Reed <chyltonreed@gmail.com> (cherry picked from commit 0557ab1) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * fixes snapshot Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: ananzh <ananzh@amazon.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> Signed-off-by: Cameron Reed <chyltonreed@gmail.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Co-authored-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com> Co-authored-by: Cameron Reed <cameron.reed@oracle.com> Co-authored-by: Cameron Reed <chyltonreed@gmail.com>

camreedOCI requested review from ananzh, kavilla, seanneumann, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, kristenTian, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, BSFishy and curq as code owners September 21, 2023 19:57

github-actions bot added the first-time-contributor label Sep 21, 2023

camreedOCI changed the title ~~Notify deangular~~ Deangular: removes angular from notify and utils of opendashboards legacy Sep 21, 2023

camreedOCI force-pushed the notifyDeangular branch from f9514a0 to 69ba6f7 Compare September 21, 2023 20:15

camreedOCI changed the base branch from main to feature/deangular September 21, 2023 20:28

ashwin-pc reviewed Sep 21, 2023

View reviewed changes

ashwin-pc added the de-angular de-angularize work label Sep 21, 2023

camreedOCI force-pushed the notifyDeangular branch 2 times, most recently from bb52e1c to 5459544 Compare September 22, 2023 21:03

ashwin-pc approved these changes Sep 22, 2023

View reviewed changes

abbyhu2000 force-pushed the feature/deangular branch from f14c199 to e6b9ab2 Compare September 22, 2023 22:54

Basic working version of OSD without angular (opensearch-project#4982)

8e24f2f

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

camreedOCI force-pushed the notifyDeangular branch 3 times, most recently from 6f1f2a4 to e1a1a8e Compare September 26, 2023 15:36

deangularized notify and utils folders in the opendashboards legacy d…

1d551a5

…irectory Signed-off-by: Cameron Reed <chyltonreed@gmail.com>

camreedOCI force-pushed the notifyDeangular branch from e1a1a8e to 1d551a5 Compare September 26, 2023 17:32

Merge branch 'feature/deangular' into notifyDeangular

bc454ad

ashwin-pc merged commit 61f40ea into opensearch-project:feature/deangular Sep 28, 2023
50 of 52 checks passed

ashwin-pc added a commit to ashwin-pc/OpenSearch-Dashboards that referenced this pull request Sep 28, 2023

followup fixes from opensearch-project#5085

fc3e88a

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

ashwin-pc mentioned this pull request Sep 28, 2023

[Discover] Misc fixes #5114

Merged

8 tasks

ashwin-pc mentioned this pull request Oct 3, 2023

[Manual backport 2.x][Deangular] OSD without angular (#5086) #5177

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deangular: removes angular from notify and utils of opendashboards legacy #5085

Deangular: removes angular from notify and utils of opendashboards legacy #5085

camreedOCI commented Sep 21, 2023 •

edited

Loading

ashwin-pc left a comment

ashwin-pc Sep 21, 2023

ashwin-pc Sep 21, 2023

ashwin-pc Sep 21, 2023

ashwin-pc Sep 21, 2023

ashwin-pc Sep 21, 2023

codecov bot commented Sep 21, 2023 •

edited

Loading

ashwin-pc left a comment

ashwin-pc Sep 22, 2023 •

edited

Loading

ashwin-pc commented Sep 28, 2023

Deangular: removes angular from notify and utils of opendashboards legacy #5085

Deangular: removes angular from notify and utils of opendashboards legacy #5085

Conversation

camreedOCI commented Sep 21, 2023 • edited Loading

Description

Issues Resolved

Screenshot

Testing the changes

Check List

ashwin-pc left a comment

Choose a reason for hiding this comment

ashwin-pc Sep 21, 2023

Choose a reason for hiding this comment

ashwin-pc Sep 21, 2023

Choose a reason for hiding this comment

ashwin-pc Sep 21, 2023

Choose a reason for hiding this comment

ashwin-pc Sep 21, 2023

Choose a reason for hiding this comment

ashwin-pc Sep 21, 2023

Choose a reason for hiding this comment

codecov bot commented Sep 21, 2023 • edited Loading

Codecov Report

ashwin-pc left a comment

Choose a reason for hiding this comment

ashwin-pc Sep 22, 2023 • edited Loading

Choose a reason for hiding this comment

ashwin-pc commented Sep 28, 2023

camreedOCI commented Sep 21, 2023 •

edited

Loading

codecov bot commented Sep 21, 2023 •

edited

Loading

ashwin-pc Sep 22, 2023 •

edited

Loading