Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual backport 2.x][Deangular] OSD without angular (#5086) #5200

Merged

Conversation

ashwin-pc
Copy link
Member

Description

Redo #5177 since the previous one was merged out of order

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

ashwin-pc and others added 2 commits October 3, 2023 03:00
* Basic working version of OSD without angular (opensearch-project#4982)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Data Explorer][Discover 2.0] Implement saved search embeddable (opensearch-project#5081)

* [Data Explorer][Discover 2.0] Implement saved search embeddable

Issue Resolve
opensearch-project#4233

---------

Signed-off-by: ananzh <ananzh@amazon.com>

* Deangular: removes angular paginate, cleanup data plugin and tilemap (opensearch-project#5060)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Data Explorer] Delete legacy discover selenium tests (opensearch-project#5088)

* delete legacy discover functional tests

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* remove discover folder in config file

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Data Explorer][Discover][Function Test] Fix ciGroup4 (opensearch-project#5099)

* add data-render-complete and data-shared-item for test convenience
* change docTableFieldCount to dataGridTableCellCount to fetch data grid cell
* add methods in data grid service to reuse current massive selenium tests
* update tests

Issue Resolve
opensearch-project#5098
opensearch-project#5058

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* [Data Explorer][Discover][Functional Test] fix ciGroup 8 (opensearch-project#5104)

Update index pattern fetch method in discover page due to changing to EuiComboBox.

Issue Resolve
opensearch-project#5103

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Fix cigroup 1 with dataGridTable helper functions (opensearch-project#5105)

* fix1

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix 1

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix anchor test

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix cigroup1

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* address comments

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Data Explorer] Fix functional cigroup 3 for save search on dashboard filtering (opensearch-project#5111)

* fix cigroup3

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* fix error

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

---------

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* add data-shared-item tag (opensearch-project#5119)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* Modifying html tests to utilize jsx and fixing tests to include all pluginPaths (opensearch-project#5080)

Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>

* fix cigroup6 (opensearch-project#5125)

Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>

* [Discover] Search on load fix (opensearch-project#5112)

* fixes search on load

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Fixes search after initial page load

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* [Data Explorer][Discover][Functional Test] Fix ciGroup7 (opensearch-project#5131)

* [Data Explorer][Discover][Functional Test] Fix ciGroup7

Issue Resolve
opensearch-project#5129

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* restore _discover_navigation

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>

* Deangular: removes angular from notify and utils of opendashboards legacy (opensearch-project#5085)

* Basic working version of OSD without angular (opensearch-project#4982)

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* deangularized notify and utils folders in the opendashboards legacy directory

Signed-off-by: Cameron Reed <chyltonreed@gmail.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Cameron Reed <chyltonreed@gmail.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Co-authored-by: Cameron Reed <chyltonreed@gmail.com>

* [Discover] Misc fixes (opensearch-project#5114)

* Canvas scrolling fix, remove notice and improve flyout focus

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Hide action icons unless hovered or focussed on

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* followup fixes from opensearch-project#5085

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: ananzh <ananzh@amazon.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>
Signed-off-by: Cameron Reed <chyltonreed@gmail.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
Co-authored-by: Zashary Maskus-Lavin <zashary.maskus-lavin@oracle.com>
Co-authored-by: Cameron Reed <cameron.reed@oracle.com>
Co-authored-by: Cameron Reed <chyltonreed@gmail.com>
(cherry picked from commit 0557ab1)
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
@ashwin-pc ashwin-pc changed the title Backport/backport 5086 to 2.x [Manual backport 2.x][Deangular] OSD without angular (#5086) Oct 4, 2023
@AMoo-Miki AMoo-Miki added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry de-angular de-angularize work labels Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #5200 (a8623fc) into 2.x (d59ee39) will increase coverage by 0.30%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              2.x    #5200      +/-   ##
==========================================
+ Coverage   66.50%   66.80%   +0.30%     
==========================================
  Files        3403     3278     -125     
  Lines       65087    63042    -2045     
  Branches    10402    10028     -374     
==========================================
- Hits        43284    42118    -1166     
+ Misses      19311    18460     -851     
+ Partials     2492     2464      -28     
Flag Coverage Δ
Linux_1 35.32% <0.00%> (+0.49%) ⬆️
Linux_2 55.26% <ø> (?)
Linux_3 43.76% <ø> (-0.84%) ⬇️
Linux_4 35.55% <ø> (+0.53%) ⬆️
Windows_1 35.33% <0.00%> (+0.49%) ⬆️
Windows_2 55.23% <ø> (-0.08%) ⬇️
Windows_3 43.76% <ø> (-0.85%) ⬇️
Windows_4 35.55% <ø> (+0.53%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/osd-ui-shared-deps/index.js 100.00% <ø> (ø)
src/plugins/dashboard/public/plugin.tsx 0.00% <ø> (ø)
...ugins/data/common/search/aggs/utils/prop_filter.ts 100.00% <ø> (ø)
...s/data/common/search/aggs/utils/to_angular_json.ts 0.00% <ø> (ø)
.../data_explorer/public/components/sidebar/index.tsx 3.12% <ø> (ø)
src/plugins/discover/common/index.ts 100.00% <ø> (ø)
...n/components/doc_viewer_links/doc_viewer_links.tsx 100.00% <ø> (ø)
.../application/components/sidebar/discover_field.tsx 84.84% <ø> (ø)
...rc/plugins/discover/public/embeddable/constants.ts 100.00% <ø> (ø)
src/plugins/discover/public/index.ts 0.00% <ø> (ø)
... and 3 more

... and 40 files with indirect coverage changes

@AMoo-Miki AMoo-Miki merged commit 31e91ef into opensearch-project:2.x Oct 4, 2023
56 of 58 checks passed
@ananzh
Copy link
Member

ananzh commented Oct 4, 2023

This is a backport of #5086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
de-angular de-angularize work Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants