Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire dashboards management #138

Merged
merged 7 commits into from
Sep 14, 2023
Merged

Conversation

raintygao
Copy link
Collaborator

Description

Retire dashboards management

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2023

Codecov Report

Merging #138 (c0da9a1) into workspace (6231768) will decrease coverage by 0.06%.
Report is 2 commits behind head on workspace.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           workspace     #138      +/-   ##
=============================================
- Coverage      65.77%   65.72%   -0.06%     
=============================================
  Files           3336     3336              
  Lines          64616    64651      +35     
  Branches       10305    10319      +14     
=============================================
- Hits           42501    42491      -10     
- Misses         19565    19610      +45     
  Partials        2550     2550              
Flag Coverage Δ
Linux_1 34.75% <ø> (+<0.01%) ⬆️
Linux_2 54.66% <ø> (-0.07%) ⬇️
Linux_3 42.51% <ø> (-0.06%) ⬇️
Linux_4 34.65% <ø> (-0.04%) ⬇️
Windows_1 34.76% <ø> (-0.04%) ⬇️
Windows_2 54.63% <ø> (-0.07%) ⬇️
Windows_3 42.52% <ø> (-0.06%) ⬇️
Windows_4 34.65% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/plugins/advanced_settings/public/plugin.ts 22.22% <ø> (ø)
...page/overview_page_header/overview_page_header.tsx 63.63% <ø> (ø)
.../plugins/saved_objects_management/public/plugin.ts 72.00% <ø> (+3.03%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
Signed-off-by: tygao <tygao@amazon.com>
@raintygao raintygao merged commit d7dbedf into ruanyl:workspace Sep 14, 2023
42 of 47 checks passed
@opensearch-workspace-development

The backport to workspace-2.9 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9 workspace-2.9
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9
# Create a new branch
git switch --create backport/backport-138-to-workspace-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d7dbedf2848204c7ad615d26f2865d49db147143
# Push it to GitHub
git push --set-upstream origin backport/backport-138-to-workspace-2.9
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9

Then, create a pull request where the base branch is workspace-2.9 and the compare/head branch is backport/backport-138-to-workspace-2.9.

ruanyl pushed a commit that referenced this pull request Sep 15, 2023
* feat: retire management section

Signed-off-by: tygao <tygao@amazon.com>

* fix: fix path

Signed-off-by: tygao <tygao@amazon.com>

* chore: remove unused

Signed-off-by: tygao <tygao@amazon.com>

* fix: update path

Signed-off-by: tygao <tygao@amazon.com>

* fix: update path

Signed-off-by: tygao <tygao@amazon.com>

* chore: remove unused after rebase

Signed-off-by: tygao <tygao@amazon.com>

* fix: remove extra import

Signed-off-by: tygao <tygao@amazon.com>

---------

Signed-off-by: tygao <tygao@amazon.com>
raintygao added a commit that referenced this pull request Sep 15, 2023
* feat: retire management section

Signed-off-by: tygao <tygao@amazon.com>

* fix: fix path

Signed-off-by: tygao <tygao@amazon.com>

* chore: remove unused

Signed-off-by: tygao <tygao@amazon.com>

* fix: update path

Signed-off-by: tygao <tygao@amazon.com>

* fix: update path

Signed-off-by: tygao <tygao@amazon.com>

* chore: remove unused after rebase

Signed-off-by: tygao <tygao@amazon.com>

* fix: remove extra import

Signed-off-by: tygao <tygao@amazon.com>

---------

Signed-off-by: tygao <tygao@amazon.com>
(cherry picked from commit d7dbedf)
SuZhou-Joe pushed a commit that referenced this pull request Sep 16, 2023
* feat: retire management section

Signed-off-by: tygao <tygao@amazon.com>

* fix: fix path

Signed-off-by: tygao <tygao@amazon.com>

* chore: remove unused

Signed-off-by: tygao <tygao@amazon.com>

* fix: update path

Signed-off-by: tygao <tygao@amazon.com>

* fix: update path

Signed-off-by: tygao <tygao@amazon.com>

* chore: remove unused after rebase

Signed-off-by: tygao <tygao@amazon.com>

* fix: remove extra import

Signed-off-by: tygao <tygao@amazon.com>

---------

Signed-off-by: tygao <tygao@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants