Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[manually backport workspace-2.9] Retire dashboards management (#138) #171

Conversation

raintygao
Copy link
Collaborator

  • feat: retire management section

Signed-off-by: tygao tygao@amazon.com

  • fix: fix path

Signed-off-by: tygao tygao@amazon.com

  • chore: remove unused

Signed-off-by: tygao tygao@amazon.com

  • fix: update path

Signed-off-by: tygao tygao@amazon.com

  • fix: update path

Signed-off-by: tygao tygao@amazon.com

  • chore: remove unused after rebase

Signed-off-by: tygao tygao@amazon.com

  • fix: remove extra import

Signed-off-by: tygao tygao@amazon.com


Signed-off-by: tygao tygao@amazon.com
(cherry picked from commit d7dbedf)

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

* feat: retire management section

Signed-off-by: tygao <tygao@amazon.com>

* fix: fix path

Signed-off-by: tygao <tygao@amazon.com>

* chore: remove unused

Signed-off-by: tygao <tygao@amazon.com>

* fix: update path

Signed-off-by: tygao <tygao@amazon.com>

* fix: update path

Signed-off-by: tygao <tygao@amazon.com>

* chore: remove unused after rebase

Signed-off-by: tygao <tygao@amazon.com>

* fix: remove extra import

Signed-off-by: tygao <tygao@amazon.com>

---------

Signed-off-by: tygao <tygao@amazon.com>
(cherry picked from commit d7dbedf)
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2023

Codecov Report

Merging #171 (ebe0ec6) into workspace-2.9 (b33221a) will increase coverage by 0.00%.
Report is 2 commits behind head on workspace-2.9.
The diff coverage is 0.00%.

@@              Coverage Diff               @@
##           workspace-2.9     #171   +/-   ##
==============================================
  Coverage          54.72%   54.72%           
==============================================
  Files               3038     3038           
  Lines              60497    60490    -7     
  Branches            9528     9527    -1     
==============================================
- Hits               33108    33106    -2     
+ Misses             25446    25441    -5     
  Partials            1943     1943           
Flag Coverage Δ
Linux_1 34.77% <0.00%> (+<0.01%) ⬆️
Linux_3 42.74% <0.00%> (+<0.01%) ⬆️
Linux_4 34.70% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...c/core/public/chrome/ui/header/collapsible_nav.tsx 0.00% <0.00%> (ø)
src/core/utils/default_app_categories.ts 100.00% <ø> (ø)
src/plugins/advanced_settings/public/plugin.ts 22.22% <ø> (ø)
...page/overview_page_header/overview_page_header.tsx 63.63% <ø> (ø)
.../plugins/saved_objects_management/public/plugin.ts 72.00% <ø> (+3.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@raintygao raintygao merged commit e7b3bb3 into ruanyl:workspace-2.9 Sep 15, 2023
20 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants