feat: duplicate all and single objects #121

yuye-aws · 2023-08-31T04:19:00Z

Description

Features:

Duplicate all objects to workspaces with write permission.
Add error message when failed to copy some saved objects.

Issues Resolved

Screenshot

Testing the changes

Check List

codecov-commenter · 2023-08-31T12:36:22Z

Codecov Report

Merging #121 (1313f07) into workspace (afa373a) will decrease coverage by 0.04%.
Report is 2 commits behind head on workspace.
The diff coverage is 4.61%.

@@              Coverage Diff              @@
##           workspace     #121      +/-   ##
=============================================
- Coverage      65.71%   65.67%   -0.04%     
=============================================
  Files           3336     3336              
  Lines          64543    64587      +44     
  Branches       10285    10291       +6     
=============================================
+ Hits           42413    42420       +7     
- Misses         19574    19588      +14     
- Partials        2556     2579      +23

Flag	Coverage Δ
Linux_1	`34.74% <100.00%> (?)`
Linux_3	`42.60% <ø> (?)`
Windows_1	`34.76% <100.00%> (ø)`
Windows_2	`54.62% <ø> (ø)`
Windows_3	`42.60% <ø> (ø)`
Windows_4	`34.68% <4.61%> (-0.05%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
...nt_section/objects_table/components/copy_modal.tsx	`0.00% <0.00%> (ø)`
...gement_section/objects_table/components/header.tsx	`75.00% <ø> (+8.33%)`	⬆️
...agement_section/objects_table/components/table.tsx	`63.63% <0.00%> (-0.98%)`	⬇️
.../plugins/saved_objects_management/public/plugin.ts	`44.82% <ø> (ø)`
...ment_section/objects_table/saved_objects_table.tsx	`56.31% <20.00%> (-0.67%)`	⬇️
...ugins/saved_objects_management/public/constants.ts	`100.00% <100.00%> (ø)`

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

...s/saved_objects_management/public/management_section/objects_table/components/copy_modal.tsx

...s/dashboard/public/application/components/dashboard_top_nav/top_nav/show_duplicate_modal.tsx

src/plugins/saved_objects_management/public/constants.ts

...s/saved_objects_management/public/management_section/objects_table/components/copy_modal.tsx

Hailong-am · 2023-09-11T07:56:16Z

...ugins/saved_objects_management/public/management_section/objects_table/components/header.tsx

+                defaultMessage="Duplicate All"
+              />
+            </EuiButtonEmpty>
+          </EuiFlexItem>


we should hide duplicate related function when workspace is turned off

Hailong-am · 2023-09-11T07:58:23Z

...lugins/saved_objects_management/public/management_section/objects_table/components/table.tsx

+            isPrimary: true,
+            onClick: (object) => onCopySingle(object),
+            'data-test-subj': 'savedObjectsTableAction-duplicate',
+          },


When workspace is turned off, there should not have duplicate button.

Hailong-am

I'm not sure the snapshots have been updated, you can run test locally to see if there has any failed UT.

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

yuye-aws · 2023-09-11T10:21:35Z

I'm not sure the snapshots have been updated, you can run test locally to see if there has any failed UT.

Thanks for reminding. These snapshots fill will be updated before merging.

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* implement all duplicate copy modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add spacer after checkbox list Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add fail message for copy saved objects Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change title wording to manage library Signed-off-by: yuye-aws <yuyezhu@amazon.com> * single duplicate Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change wording Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove comment Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bug fix: keep selected saved objects info when cancel duplicate all Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix typo Signed-off-by: yuye-aws <yuyezhu@amazon.com> * use icu syntax in copy message Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bug fix: keep selected saved objects info when cancel duplicate single Signed-off-by: yuye-aws <yuyezhu@amazon.com> * set current workspace as the first option Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshot Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve conflict Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshot Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bug fix for saved object table Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshot Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove unused file Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change i18n constant Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove empty push Signed-off-by: yuye-aws <yuyezhu@amazon.com> * hide duplicate when workspace is disabled Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> (cherry picked from commit 6231768) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* implement all duplicate copy modal * add spacer after checkbox list * add fail message for copy saved objects * change title wording to manage library * single duplicate * change wording * remove comment * bug fix: keep selected saved objects info when cancel duplicate all * fix typo * use icu syntax in copy message * bug fix: keep selected saved objects info when cancel duplicate single * set current workspace as the first option * update snapshot * resolve conflict * update snapshot * bug fix for saved object table * update snapshot * remove unused file * change i18n constant * remove empty push * hide duplicate when workspace is disabled * update snapshots --------- (cherry picked from commit 6231768) Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* implement all duplicate copy modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add spacer after checkbox list Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add fail message for copy saved objects Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change title wording to manage library Signed-off-by: yuye-aws <yuyezhu@amazon.com> * single duplicate Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change wording Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove comment Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bug fix: keep selected saved objects info when cancel duplicate all Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix typo Signed-off-by: yuye-aws <yuyezhu@amazon.com> * use icu syntax in copy message Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bug fix: keep selected saved objects info when cancel duplicate single Signed-off-by: yuye-aws <yuyezhu@amazon.com> * set current workspace as the first option Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshot Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve conflict Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshot Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bug fix for saved object table Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshot Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove unused file Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change i18n constant Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove empty push Signed-off-by: yuye-aws <yuyezhu@amazon.com> * hide duplicate when workspace is disabled Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com>

* Add copy saved objects among workspaces functionality (#53) * Add copy saved objects among workspaces functionality Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix bug Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix bug Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> # Conflicts: # src/core/server/saved_objects/routes/copy.ts # src/plugins/saved_objects_management/public/constants.ts # src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx * feat: duplicate selected objects (#113) * fix typo Signed-off-by: yuye-aws <yuyezhu@amazon.com> * adjust copy modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * list workspace with write permission on copy modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add copy icon and move getcopyworkspaces function from copy_modal to saved_object table Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix duplicate error in public workspace and change copy to duplicate all in header Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bug fix: create saved objects in public workspace Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove unused import Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change validate schema Signed-off-by: yuye-aws <yuyezhu@amazon.com> * behavior subject bug fix for workspace plugin Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> # Conflicts: # src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap # src/core/server/saved_objects/permission_control/acl.test.ts # src/core/server/saved_objects/permission_control/client.ts # src/plugins/saved_objects_management/public/management_section/objects_table/components/copy_modal.tsx # src/plugins/workspace/server/plugin.ts # src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts * Saved objects page change (#123) * hide import for application home page Signed-off-by: Hailong Cui <ihailong@amazon.com> * add workpspace into gotoApp link Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove special logic for management workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * variable name change and more UTs Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> # Conflicts: # src/plugins/saved_objects_management/public/management_section/objects_table/__snapshots__/saved_objects_table.test.tsx.snap # src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/header.test.tsx.snap # src/plugins/saved_objects_management/public/management_section/objects_table/components/table.test.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/components/table.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx * feat: duplicate all and single objects (#121) * implement all duplicate copy modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add spacer after checkbox list Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add fail message for copy saved objects Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change title wording to manage library Signed-off-by: yuye-aws <yuyezhu@amazon.com> * single duplicate Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change wording Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove comment Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bug fix: keep selected saved objects info when cancel duplicate all Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix typo Signed-off-by: yuye-aws <yuyezhu@amazon.com> * use icu syntax in copy message Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bug fix: keep selected saved objects info when cancel duplicate single Signed-off-by: yuye-aws <yuyezhu@amazon.com> * set current workspace as the first option Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshot Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve conflict Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshot Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bug fix for saved object table Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshot Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove unused file Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change i18n constant Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove empty push Signed-off-by: yuye-aws <yuyezhu@amazon.com> * hide duplicate when workspace is disabled Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> # Conflicts: # src/plugins/saved_objects_management/public/constants.ts # src/plugins/saved_objects_management/public/management_section/objects_table/__snapshots__/saved_objects_table.test.tsx.snap # src/plugins/saved_objects_management/public/management_section/objects_table/components/copy_modal.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx # src/plugins/saved_objects_management/public/plugin.ts * feat: Duplicate dashboard visualize (#148) * rename copy to duplicate Signed-off-by: yuye-aws <yuyezhu@amazon.com> * duplicate in visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * duplicate in dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve conflict Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update test and snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> * re-duplicate if some objects cannot be duplicated Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove clone for dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * rename duplicateState to duplicateMode Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change workspace prop to currentWorkspace in SavedObjectsDuplicateModal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change wording Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move duplicate modal to saved_objects for reuse Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move duplicate modal to saved objects management for reuse Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove minimal duplicate modal props logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor duplicate modal props for dashboard and visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Update getDuplicateWorkspaces function Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> * update function onDuplicate for dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Update doDuplicate for visualization Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> * refactor function getDuplicateWorkspaces Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add i18n context to saved objects table duplicate modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor duplicate modal logic in saved object table Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add error message for partial duplicate failed Signed-off-by: yuye-aws <yuyezhu@amazon.com> * merge commits Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add type info for dashboard and visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remote create vis reference logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Revert "remove clone for dashboard" This reverts commit 84f77fb. * hide duplicate when workspace disabled in dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * feat: skip permission validate when no workspaces and permissions attributes (#163) * feat: skip permission validate when saved object without workspaces and permissions attributes Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add annontation to skip permission check Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: remove bind and simplify validate logic Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: remove library write for object based ACL Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> * remove get workspaces with write permission logic and add readonly props to workspace attribute Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change type definition logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Fix typo (#176) --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * remove exit workspace logic (#179) Signed-off-by: yuye-aws <yuyezhu@amazon.com> * rename copy to duplicate Signed-off-by: yuye-aws <yuyezhu@amazon.com> * duplicate in visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * duplicate in dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve conflict Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update test and snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> * re-duplicate if some objects cannot be duplicated Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove clone for dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * rename duplicateState to duplicateMode Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change workspace prop to currentWorkspace in SavedObjectsDuplicateModal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change wording Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move duplicate modal to saved_objects for reuse Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move duplicate modal to saved objects management for reuse Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove minimal duplicate modal props logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor duplicate modal props for dashboard and visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Update getDuplicateWorkspaces function Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> * update function onDuplicate for dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Update doDuplicate for visualization Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> * refactor function getDuplicateWorkspaces Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add i18n context to saved objects table duplicate modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor duplicate modal logic in saved object table Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add error message for partial duplicate failed Signed-off-by: yuye-aws <yuyezhu@amazon.com> * merge commits Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add type info for dashboard and visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remote create vis reference logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Revert "remove clone for dashboard" This reverts commit 84f77fb. * hide duplicate when workspace disabled in dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove get workspaces with write permission logic and add readonly props to workspace attribute Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change type definition logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * rename variable and function name Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change permission mode to get target workspaces when duplicate Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> Co-authored-by: Lin Wang <wonglam@amazon.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com> # Conflicts: # src/core/public/workspace/workspaces_service.ts # src/plugins/saved_objects_management/public/constants.ts # src/plugins/saved_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx # src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts * delete useless code * refactor dupicate_model code and fix test error * add duplicate all/selected saved objects unit test * add util and copy unit test Signed-off-by: yubonluo <yubonluo@amazon.com> * fix bug Signed-off-by: yubonluo <yubonluo@amazon.com> * fix unit test error Signed-off-by: yubonluo <yubonluo@amazon.com> * add all unit test and fix code error Signed-off-by: yubonluo <yubonluo@amazon.com> * revert useless modifications Signed-off-by: yubonluo <yubonluo@amazon.com> * add snapshot code Signed-off-by: yubonluo <yubonluo@amazon.com> * delete useless code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize code Signed-off-by: yubonluo <yubonluo@amazon.com> * split duplicate_modal Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize code Signed-off-by: yubonluo <yubonluo@amazon.com> * fix unit test Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize code Signed-off-by: yubonluo <yubonluo@amazon.com> * Fixed the bug that can not duplicate all saved objects Signed-off-by: yubonluo <yubonluo@amazon.com> * Fixed the bug that can not duplicate all saved objects Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize code Signed-off-by: yubonluo <yubonluo@amazon.com> * delete useless code Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: gaobinlong <gbl_long@163.com> Co-authored-by: Yuye Zhu <yuyezhu@amazon.com> Co-authored-by: Hailong Cui <ihailong@amazon.com>

yuye-aws added the Skip-Changelog label Aug 31, 2023

yuye-aws requested review from SuZhou-Joe, gaobinlong and ruanyl August 31, 2023 04:19

github-actions bot added the seasoned-contributor label Aug 31, 2023

Hailong-am reviewed Sep 1, 2023

View reviewed changes

...s/saved_objects_management/public/management_section/objects_table/components/copy_modal.tsx Outdated Show resolved Hide resolved

yuye-aws changed the title ~~feat: duplicate all objects~~ feat: duplicate all and single objects Sep 1, 2023

yuye-aws requested a review from Hailong-am September 4, 2023 08:37

yuye-aws added the backport workspace-2.9 label Sep 8, 2023

Hailong-am reviewed Sep 8, 2023

View reviewed changes

...s/dashboard/public/application/components/dashboard_top_nav/top_nav/show_duplicate_modal.tsx Outdated Show resolved Hide resolved

wanglam reviewed Sep 11, 2023

View reviewed changes

yuye-aws requested review from wanglam and Hailong-am September 11, 2023 07:34

wanglam approved these changes Sep 11, 2023

View reviewed changes

Hailong-am reviewed Sep 11, 2023

View reviewed changes

yuye-aws requested a review from Hailong-am September 11, 2023 08:58

Hailong-am approved these changes Sep 11, 2023

View reviewed changes

Hailong-am reviewed Sep 11, 2023

View reviewed changes

raintygao approved these changes Sep 11, 2023

View reviewed changes

yuye-aws added 10 commits September 11, 2023 18:08

implement all duplicate copy modal

0d5cb1e

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

add spacer after checkbox list

fa99ee2

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

add fail message for copy saved objects

e4f9eca

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

change title wording to manage library

be69563

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

single duplicate

0b1846b

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

change wording

329c5b0

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

remove comment

b40c18c

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

bug fix: keep selected saved objects info when cancel duplicate all

b3ff030

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

fix typo

807bccb

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

use icu syntax in copy message

afc3fbe

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

yuye-aws added 11 commits September 11, 2023 18:08

bug fix: keep selected saved objects info when cancel duplicate single

d65933c

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

set current workspace as the first option

b2d1fd9

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

update snapshot

a7cafe4

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

resolve conflict

e2a2c9f

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

update snapshot

33839ca

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

bug fix for saved object table

1351f33

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

update snapshot

4e62c1b

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

remove unused file

6b974b3

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

change i18n constant

b2b5d52

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

remove empty push

1b65bce

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

hide duplicate when workspace is disabled

471282e

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

update snapshots

e40e150

Signed-off-by: yuye-aws <yuyezhu@amazon.com>

yuye-aws merged commit 6231768 into ruanyl:workspace Sep 11, 2023
36 of 39 checks passed

yuye-aws deleted the duplicate_all branch September 12, 2023 06:30

opensearch-workspace-development bot mentioned this pull request Sep 12, 2023

[Backport workspace-2.9] feat: duplicate all and single objects #147

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: duplicate all and single objects #121

feat: duplicate all and single objects #121

yuye-aws commented Aug 31, 2023 •

edited

Loading

codecov-commenter commented Aug 31, 2023 •

edited

Loading

Hailong-am Sep 11, 2023

Hailong-am Sep 11, 2023

Hailong-am left a comment

yuye-aws commented Sep 11, 2023

feat: duplicate all and single objects #121

feat: duplicate all and single objects #121

Conversation

yuye-aws commented Aug 31, 2023 • edited Loading

Description

Issues Resolved

Screenshot

Testing the changes

Check List

codecov-commenter commented Aug 31, 2023 • edited Loading

Codecov Report

Hailong-am Sep 11, 2023

Choose a reason for hiding this comment

Hailong-am Sep 11, 2023

Choose a reason for hiding this comment

Hailong-am left a comment

Choose a reason for hiding this comment

yuye-aws commented Sep 11, 2023

yuye-aws commented Aug 31, 2023 •

edited

Loading

codecov-commenter commented Aug 31, 2023 •

edited

Loading