Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling native ttl option for metastore #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mje113
Copy link
Contributor

@mje113 mje113 commented Oct 28, 2013

If an EntityStore for a given entry was purged at the cache level--due to its native ttl--the corresponding MetaStore entry should be allowed to be purged as well.

@@ -80,7 +80,11 @@ def store(request, response, entity_store)
headers.delete 'Age'

entries.unshift [stored_env, headers]
write key, entries
if request.env['rack-cache.use_native_ttl']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test for this ?

@grosser
Copy link
Collaborator

grosser commented Oct 8, 2015

can we use a constant for the string ?

@grosser
Copy link
Collaborator

grosser commented Oct 8, 2015

best also include mezis@ceb675d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants