Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No TTL set on entity keys #3

Closed
bencrouse opened this issue Oct 30, 2014 · 8 comments
Closed

No TTL set on entity keys #3

bencrouse opened this issue Oct 30, 2014 · 8 comments

Comments

@bencrouse
Copy link

Our Redis instance filled up with keys because there's no TTL set on the entity keys. I see that Rack::Cache doesn't provide TTL to the MetaStore#write method, but I'm wondering if there's a suggested workaround or fix that could be done to prevent an unbounded number of keys. I'd be willing to do the work if there's an acceptable solution.

@mezis
Copy link
Contributor

mezis commented Jun 8, 2015

+1
Seeing this as an issue as well.

@radar
Copy link
Member

radar commented Jun 8, 2015

@mezis Has this now been fixed by redis-store/redis-store#209?

@mezis
Copy link
Contributor

mezis commented Jun 9, 2015

@radar it has indeed. Sorry I didn't ping back to this issue!

@mezis
Copy link
Contributor

mezis commented Jun 9, 2015

Well, to be specific, when use_native_ttl is set and using redis-store >= 1.1.5, the entity store no longer eventually overflows.

The metastore still doesn't support native TTLs.

@bencrouse
Copy link
Author

we were experiencing the problem with the metastore keys.

@radar
Copy link
Member

radar commented Jun 10, 2015

Ok. Is another patch needed here?

@mezis
Copy link
Contributor

mezis commented Jun 10, 2015

@radar there would, but the issue has to be solved in Rack::Cache itself first. At the moment use_native_ttl isn't honoured by the metastore.

rtomayko/rack-cache#92 has a proposed fix but it's been open for a long while.

@tubbo
Copy link
Contributor

tubbo commented Nov 25, 2015

Fixed by #4 and #5.

@tubbo tubbo closed this as completed Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants