Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client error console and duplicate input/output binding errors #3931

Merged
merged 36 commits into from
Nov 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
9fff295
Add client-side error web-component and hook up to initialization errors
nstrayer Oct 27, 2023
0c0f717
Get error console looking better and able to detect custom errors and…
nstrayer Oct 27, 2023
f4bc161
Catch duplicate input and output bindings before they're bound so we …
nstrayer Oct 30, 2023
74dac7a
Add container element that allows display of more than one error message
nstrayer Oct 30, 2023
f96e117
Improve error messages
nstrayer Oct 30, 2023
31085a4
Enforce headline in all error messages
nstrayer Oct 30, 2023
ad0feeb
Add support for Dynamic UI
nstrayer Oct 30, 2023
6a174b7
Move ID tracking out to global scope so they can catch duplicates acr…
nstrayer Oct 30, 2023
73d2a23
Update logic so the container component has most of the style/logic i…
nstrayer Nov 2, 2023
582d851
Make background a bit lighter and add an outline to make it more visible
nstrayer Nov 3, 2023
a9deb3c
Switch location of try-catch to the action queue so we catch pretty m…
nstrayer Nov 3, 2023
fc5c6d5
Add copy to clipboard button and animations for showing and confirmin…
nstrayer Nov 6, 2023
1f499fd
Add check across input and output IDs for duplicates
nstrayer Nov 6, 2023
4e0dd98
Cleanup styling a bit
nstrayer Nov 6, 2023
338e0d8
Tweak spacing and sizing of line decoration on side of error messages
nstrayer Nov 6, 2023
f56c0ab
Improve wording of error message to reflect that binding errors can b…
nstrayer Nov 8, 2023
455bfc5
Add message about what console actually is and some more padding
nstrayer Nov 8, 2023
904190a
Prevent the console from getting taller than the screen
nstrayer Nov 13, 2023
6e9f8b4
Switch copy animation to a flip to check mark on the button rather t…
nstrayer Nov 14, 2023
8812fd0
Move client error definition to a new script
nstrayer Nov 14, 2023
f41f6c9
Create error with helper function but don't throw it.
nstrayer Nov 14, 2023
e9cfdaa
Abstract logic for keeping track of bindings to helper functions that…
nstrayer Nov 14, 2023
cf50ff4
Add logic for not allowing empty ids into the registery
nstrayer Nov 14, 2023
62eb485
Remove now-redundent boundInputs object
nstrayer Nov 14, 2023
aaef76d
No need to tell typescript to not complain about dangling promises be…
nstrayer Nov 14, 2023
0cff500
Simplify the binding registery to not care about differences between …
nstrayer Nov 14, 2023
aa3fe89
Revert "Simplify the binding registery to not care about differences …
nstrayer Nov 14, 2023
34cf27e
Refactor the bindings registery to just have three methods: add, remo…
nstrayer Nov 14, 2023
a58b6cb
Improve comments explaining why and what we're doing for the new regi…
nstrayer Nov 14, 2023
c60cbc9
Use <pre> tag for error message to preserve line-breaks and improve f…
nstrayer Nov 14, 2023
f621b39
Fix comments from latest PR review
nstrayer Nov 15, 2023
fac7a75
Merge remote-tracking branch 'refs/remotes/origin/main'
nstrayer Nov 15, 2023
c7510bf
`yarn build` (GitHub Actions)
nstrayer Nov 15, 2023
e335b07
Merge branch 'main' into client-error-console
wch Nov 27, 2023
d59fd9a
Update NEWS
wch Nov 27, 2023
06f87e5
Update yarn.lock
wch Nov 27, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# shiny (development version)

## New features and improvements

* Added an console that shows some errors in the browser. Also provide better error messages for duplicate input and output bindings. (#3931)

# shiny 1.8.0

## Breaking changes
Expand All @@ -15,7 +19,7 @@

* Default styles for `showNotification()` were tweaked slightly to improve accessibility, sizing, and padding. (#3913)

* Shiny inputs and `{htmlwidgets}` are no longer treated as draggable inside of `absolutePanel()`/`fixedPanel()` with `draggable = TRUE`. As a result, interactions like zooming and panning now work as expected with widgets like `{plotly}` and `{leaflet}` when they appear in a draggable panel. (#3752, #3933)
* Shiny inputs and `{htmlwidgets}` are no longer treated as draggable inside of `absolutePanel()`/`fixedPanel()` with `draggable = TRUE`. As a result, interactions like zooming and panning now work as expected with widgets like `{plotly}` and `{leaflet}` when they appear in a draggable panel. (#3752, #3933)

* For `InputBinding`s, the `.receiveMessage()` method can now be asynchronous or synchronous (previously it could only be synchronous). (#3930)

Expand Down
23,752 changes: 14,084 additions & 9,668 deletions inst/www/shared/shiny.js

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions inst/www/shared/shiny.js.map

Large diffs are not rendered by default.

17 changes: 16 additions & 1 deletion inst/www/shared/shiny.min.js

Large diffs are not rendered by default.

8 changes: 4 additions & 4 deletions inst/www/shared/shiny.min.js.map

Large diffs are not rendered by default.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
"@types/datatables.net": "^1.10.19",
"@types/ion-rangeslider": "2.3.0",
"@types/jquery": "3.5.14",
"@types/selectize": "0.12.34"
"@types/selectize": "0.12.34",
"lit": "^3.0.0"
},
"devDependencies": {
"@babel/core": "^7.14.3",
Expand Down
Loading
Loading