Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client error console and duplicate input/output binding errors #3931

Merged
merged 36 commits into from
Nov 27, 2023
Merged

Client error console and duplicate input/output binding errors #3931

merged 36 commits into from
Nov 27, 2023

Commits on Oct 27, 2023

  1. Add client-side error web-component and hook up to initialization errors

    @nstrayer
    nstrayer committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    9fff295 View commit details
    Browse the repository at this point in the history

  2. Get error console looking better and able to detect custom errors and… 

    … display better messages
    @nstrayer
    nstrayer committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    0c0f717 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Catch duplicate input and output bindings before they're bound so we … 

    …can pass more informative error messages
    @nstrayer
    nstrayer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    f4bc161 View commit details
    Browse the repository at this point in the history

  2. Add container element that allows display of more than one error message

    @nstrayer
    nstrayer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    74dac7a View commit details
    Browse the repository at this point in the history

  3. Improve error messages

    @nstrayer
    nstrayer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    f96e117 View commit details
    Browse the repository at this point in the history

  4. Enforce headline in all error messages

    @nstrayer
    nstrayer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    31085a4 View commit details
    Browse the repository at this point in the history

  5. Add support for Dynamic UI

    @nstrayer
    nstrayer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    ad0feeb View commit details
    Browse the repository at this point in the history

  6. Move ID tracking out to global scope so they can catch duplicates acr… 

    …oss init and dynamic renders
    @nstrayer
    nstrayer committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    6a174b7 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Update logic so the container component has most of the style/logic i… 

    …n it. Also add a close button and a collapse one
    @nstrayer
    nstrayer committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    73d2a23 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Make background a bit lighter and add an outline to make it more visible

    @nstrayer
    nstrayer committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    582d851 View commit details
    Browse the repository at this point in the history

  2. Switch location of try-catch to the action queue so we catch pretty m… 

    …uch any error going on during the shiny "runtime"
    @nstrayer
    nstrayer committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    a9deb3c View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Add copy to clipboard button and animations for showing and confirmin… 

    …g selection/copy
    @nstrayer
    nstrayer committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    fc5c6d5 View commit details
    Browse the repository at this point in the history

  2. Add check across input and output IDs for duplicates

    @nstrayer
    nstrayer committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    1f499fd View commit details
    Browse the repository at this point in the history

  3. Cleanup styling a bit

    @nstrayer
    nstrayer committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    4e0dd98 View commit details
    Browse the repository at this point in the history

  4. Tweak spacing and sizing of line decoration on side of error messages

    @nstrayer
    nstrayer committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    338e0d8 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Improve wording of error message to reflect that binding errors can b… 

    …e across inputs and outputs
    @nstrayer
    nstrayer committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    f56c0ab View commit details
    Browse the repository at this point in the history

  2. Add message about what console actually is and some more padding

    @nstrayer
    nstrayer committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    455bfc5 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Prevent the console from getting taller than the screen

    @nstrayer
    nstrayer committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    904190a View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. Switch copy animation to a flip to check mark on the button rather th… 

    …an another message
    @nstrayer
    nstrayer committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    6e9f8b4 View commit details
    Browse the repository at this point in the history

  2. Move client error definition to a new script

    @nstrayer
    nstrayer committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    8812fd0 View commit details
    Browse the repository at this point in the history

  3. Create error with helper function but don't throw it.

    @nstrayer
    nstrayer committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    f41f6c9 View commit details
    Browse the repository at this point in the history

  4. Abstract logic for keeping track of bindings to helper functions that… 

    … don't expose implementation
    @nstrayer
    nstrayer committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    e9cfdaa View commit details
    Browse the repository at this point in the history

  5. Add logic for not allowing empty ids into the registery

    @nstrayer
    nstrayer committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    cf50ff4 View commit details
    Browse the repository at this point in the history

  6. Remove now-redundent boundInputs object

    @nstrayer
    nstrayer committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    62eb485 View commit details
    Browse the repository at this point in the history

  7. No need to tell typescript to not complain about dangling promises be… 

    …cause the initShiny call is no longer dangling.
    @nstrayer
    nstrayer committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    aaef76d View commit details
    Browse the repository at this point in the history

  8. Simplify the binding registery to not care about differences between … 

    …inputs and outputs
    @nstrayer
    nstrayer committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    0cff500 View commit details
    Browse the repository at this point in the history

  9. Revert "Simplify the binding registery to not care about differences … 

    …between inputs and outputs"

This reverts commit 0cff500.
    @nstrayer
    nstrayer committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    aa3fe89 View commit details
    Browse the repository at this point in the history

  10. Refactor the bindings registery to just have three methods: add, remo… 

    …ve, and validate. The validation is now done after _bindAll() is called to get a complete picture of collisions.
    @nstrayer
    nstrayer committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    34cf27e View commit details
    Browse the repository at this point in the history

  11. Improve comments explaining why and what we're doing for the new regi… 

    …stry format
    @nstrayer
    nstrayer committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    a58b6cb View commit details
    Browse the repository at this point in the history

  12. Use <pre> tag for error message to preserve line-breaks and improve f… 

    …ormatting of the duplicate id message
    @nstrayer
    nstrayer committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    c60cbc9 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Fix comments from latest PR review

    @nstrayer
    nstrayer committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    f621b39 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'refs/remotes/origin/main' 

    Conflicts:
	inst/www/shared/shiny.js
	inst/www/shared/shiny.js.map
	inst/www/shared/shiny.min.js
	inst/www/shared/shiny.min.js.map
    @nstrayer
    nstrayer committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    fac7a75 View commit details
    Browse the repository at this point in the history

  3. yarn build (GitHub Actions)

    @nstrayer
    nstrayer committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    c7510bf View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Merge branch 'main' into client-error-console

    @wch
    wch committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    e335b07 View commit details
    Browse the repository at this point in the history

  2. Update NEWS

    @wch
    wch committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    d59fd9a View commit details
    Browse the repository at this point in the history

  3. Update yarn.lock

    @wch
    wch committed Nov 27, 2023
    Configuration menu
    Copy the full SHA
    06f87e5 View commit details
    Browse the repository at this point in the history