Switch from sundown to commonmark #95

yihui · 2022-10-20T15:35:41Z

This is to fix yihui/knitr#1329.

Also close #76.

TODO:

…, 'smart' to list(smart = TRUE)

…with the original C version)

…es to be ironed out)

…se special cases)

…tead

…stead

…fragment_only' instead

…n CI servers like GHA or devtools::check(), so that these won't affect end-users but only developers

…down/blob/cc2b149c2ae06eb9a2c7a5c8251cf4f13ff00c5a/tests/testthat/test-6.14-textual-content.R#L12

…hub.com/PolMine/polmineR/blob/master/tests/testthat/test_as.markdown.R so tweak the results for polmineR

…d to set the `fragment_only` option

…lease of xfun

… line is empty

…tex output accordingly

…nd markdownToLaTeX() to mark_latex() for easier typing

cderv · 2022-10-28T09:26:34Z

Awesome @yihui!

Thanks for doing it !

yihui added 30 commits October 19, 2022 11:40

delete sundown

9a44718

markdown -> Markdown, and mark some functions as internal

8b3445e

bootcss -> rstudio cdn for mathjax

b11c1aa

delete some options, and normalize character options to boolean, e.g.…

1fc067d

…, 'smart' to list(smart = TRUE)

a plain R implementation of smartypants() (not completely compatible …

8d20929

…with the original C version)

remove rendererOutputType()

c573580

alias the option hard_wrap to hardbreaks

b3609fd

rewrite .b64EncodeImages() and call xfun::base64_uri()

c557804

a basic version using commonmark is working now (still many rough edg…

0a8550b

…es to be ironed out)

no need special handling here (commonmark::markdown_*() can handle th…

5eb297e

…se special cases)

delete the test for base64 encoding

eba22db

import utils for getFromNamespace()

e44b001

rename HTMLOptions.R to render-options.R

5dfde60

merge markdownExtensions.R into render-options.R

5084170

factor out pkg_file() as a wrapper of system.file(package = 'markdown')

9c3dcc3

use xfun::in_dir()

3e38b0b

remove markdownExtensions() and merge extensions into options ins…

c50ac26

…tead

warn against the old 'stylesheet' argument and suggest using 'css' in…

8be98b3

…stead

warn against the fragment.only argument and suggest using options = '…

5c94e3a

…fragment_only' instead

keep .b64EncodeFile() for now: rstudio/leaflet#823

0a56cf6

add markdownExtensions() back for now: rstudio/learnr#745

519aa57

temporarily add the option back for PolMine/polmineR#232

6298d6c

temporarily added back

ab1b501

set the option only for the polmineR package: PolMine/polmineR#232

2a0ffcd

signal the warnings only when doing CRAN incoming checks or running o…

fe655d1

…n CI servers like GHA or devtools::check(), so that these won't affect end-users but only developers

some hacks for packages that would be broken

a7de2e3

mention changes about stylesheet and fragment.only arguments

6184345

disable smart option for gluedown: https://github.com/kiernann/glue…

38eb97a

…down/blob/cc2b149c2ae06eb9a2c7a5c8251cf4f13ff00c5a/tests/testthat/test-6.14-textual-content.R#L12

tweak examples

d10e784

polmineR's tests are too strict in terms of white spaces: https://git…

7b5e797

…hub.com/PolMine/polmineR/blob/master/tests/testthat/test_as.markdown.R so tweak the results for polmineR

yihui added 10 commits October 23, 2022 22:09

implement the latex_math option for html and latex output

ccb4188

use renderMarkdown() instead of markdownToHTML() so that we don't nee…

a1f1bef

…d to set the `fragment_only` option

use dev version of xfun

fa1acab

implement ^superscript^ and ~subscript~

74b3ca8

don't add ## to output

4b14b2c

implement toc

e089a7c

rename fragment_only to standalone to be more consistent with pandoc

b147386

document the options argument in more detail

6ff0dd1

copy functions from xfun so that I don't need to wait for the next re…

9b7fa8a

…lease of xfun

a less smart way to generate the HTML entities

f0fc08f

yihui self-assigned this Oct 25, 2022

yihui added 16 commits October 25, 2022 13:44

change the option fragment_only to -standalone

a3eaacc

the trailing spaces may be on the second but last line, when the last…

6004385

… line is empty

always split text input into lines

96c83e8

allow the file argument to accept Markdown text input

bf56456

move the base64_images into renderMarkdown()

9533a70

all tags should be lowercase

ffaa2a6

deal with fragment.only = TRUE earlier

e16d995

make the template work for arbitrary metadata, and add support for la…

c08fe92

…tex output accordingly

rename scripts

5557c48

rename renderMarkdown() to mark(), markdownToHTML() to mark_html(), a…

8acffca

…nd markdownToLaTeX() to mark_latex() for easier typing

rename markdownOptions() to markdown_options()

a99c403

more camel to snake case

f129bf4

roxygenize

6f1b431

update test output

7860143

correct argument order

a2912c6

tweak news [ci skip]

db61947

yihui merged commit 1c7b4a1 into master Oct 27, 2022

yihui deleted the commonmark branch October 27, 2022 18:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch from sundown to commonmark #95

Switch from sundown to commonmark #95

yihui commented Oct 20, 2022 •

edited

Loading

cderv commented Oct 28, 2022

Switch from sundown to commonmark #95

Switch from sundown to commonmark #95

Conversation

yihui commented Oct 20, 2022 • edited Loading

cderv commented Oct 28, 2022

yihui commented Oct 20, 2022 •

edited

Loading