Allow any number of \n in the test
#31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the next version of the **markdown** package, it will generate only one `\n` instead of two. Using `expect_match()` can deal with both cases.
9 tasks
|
@filipsch Is there a chance that you could merge this and make a new CRAN release? Thank you! |
to get rid of the CRAN note: https://cran.r-project.org/web/checks/check_results_tutorial.html Version: 0.4.3 Check: LazyData Result: NOTE 'LazyData' is specified without a 'data' directory
|
@yihui This project is not being actively maintained anymore. What can I do to no longer make this a nuisance for you when you want to update knitr or other packages |
|
Yes, you can email CRAN and ask them to archive this package if it's no longer maintained. Then I won't have problems if I make a change in my package that will break this package's test. Thank you so much! |
|
I just sent an email. If they get back to me, I will let you know and update the README of this package accordingly. |
|
@yihui Kurt Hornik let me know tutorial is archived now. |
|
Perfect. Thanks again! |
yihui
added a commit
to rstudio/markdown
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The markdown package v1.3 generates only one
\ninstead of two. Usingexpect_match()can deal with both cases.