-
Notifications
You must be signed in to change notification settings - Fork 214
Improvements to grid context as_gtable()
+ plot.gt_tbl()
#1788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
as_gtable()
+ plot.gt_tbl()
I don't think we should limit grid table output to those using R 4.2 or later in practice (unless there are errors). The better thing to do might be to include some notes about this in the new FAQ section (great addition btw!). The topic could generally outline the capabilities/problems of the different table output types. The context of One more thing, we ought to think of visual tests or just additional Quarto websites for grid-table outputs (and also for LaTeX, that's probably more important). I'll try working on this a bit (the Quarto website for grid-table examples) and I think it just involves adding a plot statement to certain example statements that produce a gt table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It doesn't look unreasonable, but I don't really know what
You can, but it is an extra suggest dependency that I'm not sure pays off here. For testing purposes the Line 1194 in 34fd17f
No grid should render unicode just fine even before R 4.2.0 I think so this shouldn't be cause for worry. Potentially it could be the case that a unicode glyph is not in the font, so it might render as missing characters in devices that don't have font fallbacks. But that's just a limitation, so there is nothing that {gt} can do here. |
Maybe I can provide an explanation here. It feels a bit magical, but since the currencies are stored in html strings, I discovered that |
Summary
sub_*()
+cols_merge()
functionsfmt_markdown()
<br>
to \n Make<br>
a universal linebreak across formats #1767context = "grid"
to some functions@teunbrand I'd love to have your views here in general.
Related GitHub Issues and PRs
<br>
a universal linebreak across formats #1767@rich-iannone I am not too sure if I am duplicating things here. Not clear to me how context = "plain" vs context ="grid" should act.
It is just that grid renders unicode formats, since R 4.2 I think?
Do you think we may add some conditions on R version for some grid features? i.e. if context = "grid" and R version < 4.2, use plain text rendering?
Examples
This PR resolves the following to look the same in html and grid
Previously, we would see
<br>