More styling for opt_interactive() + new visual tests for different output formats
#1766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivroy
changed the title
opt_interactive()opt_interactive()
…ames and row group labels. Part of rstudio#1693
Merge commit 'e56c3f411994fd7910f1ff428b0d74fc758ce8fe' #Conflicts: # .github/workflows/pkgdown.yaml # NEWS.md # tests/testthat/test-opt_functions.R # vignettes/case-study-gtcars.Rmd # vignettes/gt-datasets.Rmd # vignettes/gt.Rmd
Update script
Update actions
Update result with `source("scripts/visual-tests-latex.R")`
|
Let me know what you think! Here is my attempt at verifying cross-output.
There still is a bit of copy-paste needed to add more visual tests in gt-visual.qmd. I will have to think about this more. |
olivroy
changed the title
opt_interactive()opt_interactive() + new visual tests for cross-output
|
I really like everything that's being done here! Visual testing is important for verifying that things are continuing to work properly so this is all much needed. |
olivroy
changed the title
opt_interactive() + new visual tests for cross-output opt_interactive() + new visual tests for different output formats
|
@olivroy I noticed this is no longer a draft PR, but, you also mentioned things left to do (but could very well be in a new PR). Given all that, is this PR ready for review / merging? |
|
Never mind, just saw 'ready for review' up above. Will get to that now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Wonder if there is a better way to do this other than to mix and match different ihtml features.
as_gtable()+plot.gt_tbl()#1788 (comment)Will use this PR to make some updates as I see them fit, and will let you know once it is ready for review. I don't understand some of the code. I wonder if there is a way to do this more smoothly / automatically?
Checklist
testthatunit tests totests/testthatfor any new functionality.