Improve error message for rm_spanners(), rm_footnotes(), and rm_source_notes()
#1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers()`, and `rm_source_notes()`
olivroy
commented
May 13, 2024
|
This is great! Thanks for these little fixes, they make a difference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
took advantage of the
item_labelargument ofresolve_vector_i()For review, I highly recommend looking at both commits separately as the changes made to the code are in e498583
I made some test refactoring to use snapshots in 0a6e2e7
This builds on top of previous PRs that improved error messages recently such as #1638, #1640. I also have other things locally, but I will try to send them in digestible chunks as much as possible!
Related GitHub Issues and PRs
tab_footnote()error message #1638Checklist
testthatunit tests totests/testthatfor any new functionality.