Improve tab_style() error messages when locations is invalid
#1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivroy
changed the title
tab_style() error messages when locations is invalid
|
Thank you for this. And the wording used is great here! Could you prefix any Also, could you add yourself as an author to the authors list? You've done a lot of really excellent work here! |
olivroy
commented
Apr 25, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To follow-up on #1638.
I added a more user-friendly message.
I refactored the tests in c7fd52c where I added snapshot tests for errors notably to better assess messages and to create a better snapshot diff.
For review, I would recommend looking at 766f0dd. If you think wording could be improved, I will happily do so! Maybe with this PR, the resolve_rows/resolve_cols message could be simplified?
Checklist
testthatunit tests totests/testthatfor any new functionality.Could relate to #1608