Skip to content

cols_hide(columns) no longer required to select any columns #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 6, 2023
Merged

cols_hide(columns) no longer required to select any columns #1343

merged 4 commits into from
Jun 6, 2023

Conversation

ddsjoberg
Copy link
Contributor

@ddsjoberg ddsjoberg commented Jun 6, 2023 •
edited
Loading

Summary

  • Update to col_hide(columns=) and cols_unhide(columns=) arguments. The functions no longer return an error if no columns are selected. (cols_hide(): allow for no selection of columns #1342)
  • Also updated the R CMD Check workflow to use R version aliases so checks are always run against new versions of R when they are released.

Related GitHub Issues and PRs

closes #1342

Checklist

@ddsjoberg ddsjoberg changed the title Cols hide columns cols_hide(columns) no longer required to select any columns Jun 6, 2023
@rich-iannone rich-iannone self-requested a review June 6, 2023 17:43
rich-iannone
rich-iannone approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rich-iannone rich-iannone merged commit a2fb856 into rstudio:master Jun 6, 2023
@ddsjoberg ddsjoberg deleted the cols_hide-columns branch June 6, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rich-iannone rich-iannone rich-iannone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cols_hide(): allow for no selection of columns
2 participants
@ddsjoberg @rich-iannone