Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cols_hide(): allow for no selection of columns #1342

Closed
2 tasks done
ddsjoberg opened this issue Jun 6, 2023 · 1 comment · Fixed by #1343
Closed
2 tasks done

cols_hide(): allow for no selection of columns #1342

ddsjoberg opened this issue Jun 6, 2023 · 1 comment · Fixed by #1343

Comments

@ddsjoberg
Copy link
Contributor

Prework

Description

Hello! 🍁

Would it be possible to update cols_hide() to no longer error when no columns are selected?

Thanks!

Reproducible example

packageVersion("gt")
#> [1] '0.9.0'

gt::sp500 |> 
  gt::gt() |> 
  gt::cols_hide(columns = starts_with("xxxxx"))
#> Error in `gt::cols_hide()`:
#> ! Columns must be provided.
#> Backtrace:
#>     ▆
#>  1. └─gt::cols_hide(gt::gt(gt::sp500), columns = starts_with("xxxxx"))
#>  2.   └─cli::cli_abort("Columns must be provided.")
#>  3.     └─rlang::abort(...)

# in my real-world example, I wanted to hide columns that were all na
all_na <- function(x) all(is.na(x))

gt::sp500 |> 
  gt::gt() |> 
  gt::cols_hide(columns = where(all_na))
#> Error in `gt::cols_hide()`:
#> ! Columns must be provided.
#> Backtrace:
#>     ▆
#>  1. └─gt::cols_hide(gt::gt(gt::sp500), columns = where(all_na))
#>  2.   └─cli::cli_abort("Columns must be provided.")
#>  3.     └─rlang::abort(...)

Created on 2023-06-06 with reprex v2.0.2

Session info
sessioninfo::session_info()
#> ─ Session info ───────────────────────────────────────────────────────────────
#>  setting  value
#>  version  R version 4.3.0 (2023-04-21 ucrt)
#>  os       Windows 10 x64 (build 19044)
#>  system   x86_64, mingw32
#>  ui       RTerm
#>  language (EN)
#>  collate  English_United States.utf8
#>  ctype    English_United States.utf8
#>  tz       America/New_York
#>  date     2023-06-06
#>  pandoc   2.19.2 @ C:/Program Files/RStudio/resources/app/bin/quarto/bin/tools/ (via rmarkdown)
#> 
#> ─ Packages ───────────────────────────────────────────────────────────────────
#>  package     * version date (UTC) lib source
#>  cli           3.6.1   2023-03-23 [1] CRAN (R 4.3.0)
#>  digest        0.6.31  2022-12-11 [1] CRAN (R 4.3.0)
#>  dplyr         1.1.2   2023-04-20 [1] CRAN (R 4.3.0)
#>  evaluate      0.21    2023-05-05 [1] CRAN (R 4.3.0)
#>  fansi         1.0.4   2023-01-22 [1] CRAN (R 4.3.0)
#>  fastmap       1.1.1   2023-02-24 [1] CRAN (R 4.3.0)
#>  fs            1.6.2   2023-04-25 [1] CRAN (R 4.3.0)
#>  generics      0.1.3   2022-07-05 [1] CRAN (R 4.3.0)
#>  glue          1.6.2   2022-02-24 [1] CRAN (R 4.3.0)
#>  gt            0.9.0   2023-03-31 [1] CRAN (R 4.3.0)
#>  htmltools     0.5.5   2023-03-23 [1] CRAN (R 4.3.0)
#>  knitr         1.43    2023-05-25 [1] CRAN (R 4.3.0)
#>  lifecycle     1.0.3   2022-10-07 [1] CRAN (R 4.3.0)
#>  magrittr      2.0.3   2022-03-30 [1] CRAN (R 4.3.0)
#>  pillar        1.9.0   2023-03-22 [1] CRAN (R 4.3.0)
#>  pkgconfig     2.0.3   2019-09-22 [1] CRAN (R 4.3.0)
#>  purrr         1.0.1   2023-01-10 [1] CRAN (R 4.3.0)
#>  R.cache       0.16.0  2022-07-21 [1] CRAN (R 4.3.0)
#>  R.methodsS3   1.8.2   2022-06-13 [1] CRAN (R 4.3.0)
#>  R.oo          1.25.0  2022-06-12 [1] CRAN (R 4.3.0)
#>  R.utils       2.12.2  2022-11-11 [1] CRAN (R 4.3.0)
#>  R6            2.5.1   2021-08-19 [1] CRAN (R 4.3.0)
#>  reprex        2.0.2   2022-08-17 [1] CRAN (R 4.3.0)
#>  rlang         1.1.1   2023-04-28 [1] CRAN (R 4.3.0)
#>  rmarkdown     2.22    2023-06-01 [1] CRAN (R 4.3.0)
#>  rstudioapi    0.14    2022-08-22 [1] CRAN (R 4.3.0)
#>  sessioninfo   1.2.2   2021-12-06 [1] CRAN (R 4.3.0)
#>  styler        1.10.0  2023-05-24 [1] CRAN (R 4.3.0)
#>  tibble        3.2.1   2023-03-20 [1] CRAN (R 4.3.0)
#>  tidyselect    1.2.0   2022-10-10 [1] CRAN (R 4.3.0)
#>  utf8          1.2.3   2023-01-31 [1] CRAN (R 4.3.0)
#>  vctrs         0.6.2   2023-04-19 [1] CRAN (R 4.3.0)
#>  withr         2.5.0   2022-03-03 [1] CRAN (R 4.3.0)
#>  xfun          0.39    2023-04-20 [1] CRAN (R 4.3.0)
#>  xml2          1.3.4   2023-04-27 [1] CRAN (R 4.3.0)
#>  yaml          2.3.7   2023-01-23 [1] CRAN (R 4.3.0)
#> 
#>  [1] C:/Users/SjobergD/AppData/Local/R/win-library/4.3
#>  [2] C:/Program Files/R/R-4.3.0/library
#> 
#> ──────────────────────────────────────────────────────────────────────────────

Expected result

When no columns are selected, I expected simply no columns to be hidden rather than an error

@rich-iannone
Copy link
Member

Great idea here, I think this should be done. And also done for cols_unhide()!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment