Better Tombstone handling in Iter #21
Conversation
Adds an option for iterating with tombstones but by default the Iter function skips tombstones to match the Get functionality. Also fixes the colons in namespace issue by removing the namespace prefix rather than splitting on the separator. Increases tests to ensure that Iter covers undead objects. Note, this will require a change to Trtl replication, it must use the WithTombstone option when it is iterating in initiator phase 1 and remote phase 2; otherwise deletes will not be replicated.
Codecov Report
@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 55.77% 56.41% +0.63%
==========================================
Files 10 10
Lines 554 569 +15
==========================================
+ Hits 309 321 +12
- Misses 200 203 +3
Partials 45 45
Continue to review full report at Codecov.
|
| } | ||
| } | ||
|
|
||
| func TestTombstonesMultipleNamespaces(t *testing.T) { |
| // Teardown after finishing the test | ||
| defer os.RemoveAll(ldbPath) | ||
| defer ldbEngine.Close() | ||
| ldbEngine, _ := setupLevelDBEngine(t) |
There was a problem hiding this comment.
Thanks for adding the cleanup func, it makes the teardown code a lot neater.
| iter.Release() | ||
|
|
||
| require.Equal(t, expected, actual, "database key count does not match") | ||
| } |
There was a problem hiding this comment.
Good idea to add these utilities.
| func TestTombstonesMultipleNamespaces(t *testing.T) { | ||
| // Create a test database | ||
| db, _ := setupHonuDB(t) | ||
| namespaces := []string{"graveyard", "cemetery", "catacombs"} |
| // If we aren't including Tombstones, we need to check if the next version is a | ||
| // tombstone before we know if we have a next value or not. | ||
| if !i.options.Tombstones { | ||
| if obj, err := i.Object(); err != nil || obj.Tombstone() { |
There was a problem hiding this comment.
Are we ignoring the error here or does it get captured somewhere else?
Adds an option for iterating with tombstones but by default the
Iterfunction skips tombstones to match theGetfunctionality. Also fixes the colons in namespace issue by removing the namespace prefix rather than splitting on the separator. Increases tests to ensure thatItercovers undead objects.Note, this will require a change to Trtl replication, it must use the
WithTombstoneoption when it is iterating in initiator phase 1 and remote phase 2; otherwise deletes will not be replicated.