Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namespaces with double colons bug. #14

Closed
DanielSollis opened this issue Dec 11, 2021 · 1 comment
Closed

namespaces with double colons bug. #14

DanielSollis opened this issue Dec 11, 2021 · 1 comment

Comments

@DanielSollis
Copy link
Contributor

DanielSollis commented Dec 11, 2021

Fix the issue where LevelDBEngine.Iter currently grabs the namespace by splitting on double colons (::). In the case of a namespace called for example "namespace::with::colons", Iter considers the namespace to be "namespace" and will not access the database correctly. As for a possible solution, with PR #12 the namespace is stored in the iterator, meaning we would no longer need to split on double colons. The following tests are currently skipping double colon test cases and need to be amended:

  • engines/leveldb/leveldb_test: TestLevelDBIter line 163
  • honu_test: TestLevelDBInteractions line 119
@bbengfort
Copy link
Contributor

Fixed by #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants