Update cmake min version in tinyxml cmakelists.txt script #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
changed the title
|
Rerun ci jobs
It doesn't look like tinyxml_vendor actually make use of the tinyxml_cmakelists.txt because there are no warning specific to this package on the above cmake warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the most recent release of cmake (3.19), they have started deprecating cmake versions <
2.8.12.Example cmake warnings
https://ci.ros2.org/view/nightly/job/nightly_win_rel/1760/cmake/
Build all of ros2, testing up to
rcutilsSigned-off-by: Stephen Brawner brawner@gmail.com