Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cmake minimum version to 2.8.12 #67

Merged

Conversation

brawner
Copy link
Contributor

@brawner brawner commented Nov 23, 2020

In the most recent release of cmake (3.19), they have started deprecating cmake versions < 2.8.12.

Example cmake warnings
https://ci.ros2.org/view/nightly/job/nightly_win_rel/1760/cmake/

Build all of ros2, testing up to rcutils

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: Stephen Brawner brawner@gmail.com

Signed-off-by: Stephen Brawner <brawner@gmail.com>
@sloretz
Copy link
Contributor

sloretz commented Nov 24, 2020

Looks like a typo with CI: 6 __main__.py: error: unrecognized arguments: --package-up-to. Retriggered

build: all of ROS 2; test: --packages-up-to rcutils

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Contributor

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@sloretz
Copy link
Contributor

sloretz commented Nov 24, 2020

@brawner was that CI meant to cover all the PRs? I still see some windows warnings about the minimum required version.

@brawner
Copy link
Contributor Author

brawner commented Nov 24, 2020

Thanks Shane for rerunning the CI. I was hoping to get all the cmake warnings but it appears I missed some. It looks like urdfdom_headers has been taken care of though. It's hard to tell because jenkins doesn't categorize it correctly, but it's one of the 4 resolved cmake warnings.

I think this PR will need to be backported otherwise we'll continue getting the same issues when running foxy jobs on CI.

@sloretz Are you able to merge this PR? I don't have privileges in the ros org.

@scpeters scpeters merged commit 8ec3899 into ros:master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants