Select executor in node registration #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>
HiroIshida
force-pushed
the
select_executor_in_node_registration
branch
from
f81638e to
8c4e794
Compare
HiroIshida
added a commit
to HiroIshida/autoware.universe
that referenced
this pull request
Mar 18, 2022
alsora
reviewed
Mar 18, 2022
| # default to executor if not specified otherwise | ||
| set(executor "SingleThreadedExecutor") | ||
| if(NOT "${ARGS_EXECUTOR}" STREQUAL "") | ||
| set(executor ${ARGS_EXECUTOR}) |
|
PR looks good to me!
|
Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>
HiroIshida
force-pushed
the
select_executor_in_node_registration
branch
from
891e160 to
9ddf60c
Compare
alsora
approved these changes
Mar 18, 2022
HiroIshida
added a commit
to HiroIshida/autoware.universe
that referenced
this pull request
Apr 13, 2022
HiroIshida
added a commit
to HiroIshida/rclcpp
that referenced
this pull request
Apr 13, 2022
* Select executor Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp> * Fix indent Signed-off-by: Hirokazu Ishida <h-ishida@jsk.imi.i.u-tokyo.ac.jp>
HiroIshida
added a commit
to HiroIshida/autoware.universe
that referenced
this pull request
Apr 13, 2022
HiroIshida
added a commit
to HiroIshida/autoware.universe
that referenced
this pull request
Apr 29, 2022
87 tasks
HiroIshida
added a commit
to tier4/autoware.universe
that referenced
this pull request
May 30, 2022
HiroIshida
added a commit
to tier4/autoware.universe
that referenced
this pull request
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables selection of executor type in
rclcpp_components_register_nodeinCMakeLists.txt.So far,
SingleThreadedExecutoris hard-coded.FYI, I need this option to use of
MultiThereadedExecutorbecause my node contains nested callback.