Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using the rclpy context manager everywhere. #389

Merged
merged 3 commits into from
Jul 24, 2024
Merged

Switch to using the rclpy context manager everywhere. #389

merged 3 commits into from
Jul 24, 2024

Commits on Jul 23, 2024

  1. Switch to using the rclpy context manager everywhere. 

    This lets us use less code, but still effectively
manage the lifetime of the rclpy.init.  We also
change ExternalShutdownException handling to
work just like a KeyboardInterrupt.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    8f25d28 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Small feedback from review. 

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    93877f8 View commit details
    Browse the repository at this point in the history

  2. Switch to using spin_until_future_complete. 

    Signed-off-by: Chris Lalancette <clalancette@gmail.com>
    @clalancette
    clalancette committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    e74d38d View commit details
    Browse the repository at this point in the history