Switch to using the rclpy context manager everywhere. #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us use less code, but still effectively manage the lifetime of the rclpy.init. We also change ExternalShutdownException handling to work just like a KeyboardInterrupt. Signed-off-by: Chris Lalancette <clalancette@gmail.com>
ahcorde
approved these changes
Jul 23, 2024
rclpy/actions/minimal_action_client/examples_rclpy_minimal_action_client/client_asyncio.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: Chris Lalancette <clalancette@gmail.com>
|
And here is new CI:
|
fujitatomoya
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us use less code, but still effectively
manage the lifetime of the rclpy.init. We also
change ExternalShutdownException handling to
work just like a KeyboardInterrupt.
This is one of the last PRs before we can close out ros2/rclpy#1280
@sloretz FYI
This should really be merged simultaneously with ros2/ros2_documentation#4586