Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kompass_interfaces package to rosdistro #44111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mkabtoul
Copy link
Contributor

@mkabtoul mkabtoul commented Jan 7, 2025

Please add kompass_interfaces to be indexed in the rosdistro

Package name:

kompass_interfaces

Package Upstream Source:

https://github.com/automatika-robotics/kompass.git

Purpose of using this:

kompass_interfaces contains the ROS2 interfaces (msg/srv/action) for kompass package

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

@github-actions github-actions bot added humble Issue/PR is for the ROS 2 Humble distribution jazzy Issue/PR is for the ROS 2 Jazzy distribution rolling Issue/PR is for the ROS 2 Rolling distribution labels Jan 7, 2025
@christophebedard
Copy link
Member

Looks like your IDE auto-formatted the YAML files. Can you revert those changes and just have your explicit changes?

@christophebedard christophebedard added the changes requested Maintainers have asked for changes to the pull request label Jan 7, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

@mkabtoul
Copy link
Contributor Author

mkabtoul commented Jan 8, 2025

Thanks @christophebedard , I fixed the formatting issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Maintainers have asked for changes to the pull request humble Issue/PR is for the ROS 2 Humble distribution jazzy Issue/PR is for the ROS 2 Jazzy distribution rolling Issue/PR is for the ROS 2 Rolling distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants