[naoqi_driver_py] disable odom with param #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,6 +77,7 @@ def __init__(self): | |||
|
|
|||
| # use sensor values or commanded (open-loop) values for joint angles | |||
| self.useJointSensors = rospy.get_param('~use_joint_sensors', True) # (set to False in simulation!) | |||
| self.enableOdometry = rospy.get_param('~enable_odometry', True) | |||
There was a problem hiding this comment.
enable_odometry? use_odometry? not sure which is better..
disable odometry with param get arg from launch file
Naoki-Kameyama
force-pushed
the
disable_odom
branch
from
249a0cc
to
dcdc0c4
Compare
|
Thank you for your comment. |
|
lgtm, waiting for another +1 for few days |
|
+1 |
|
thank you , committed with modified version #59 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disable odometry with param
get arg from launch file
Because I'd like to test visual SLAM.