Be specific about which parts of Boost are necessary #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JWhitleyWork
approved these changes
Jan 31, 2020
There was a problem hiding this comment.
Thanks, @gavanderhoorn! I agree with the changes but I'll hold until the upstream change is in and CI passes.
|
Of course. Agreed. |
|
Retriggering CI as ros/rosdistro#23624 got merged. |
JWhitleyWork
approved these changes
Feb 6, 2020
JWhitleyWork
pushed a commit
that referenced
this pull request
Jul 25, 2020
This reverts commit 7660c2a.
reza-ebrahimi
pushed a commit
to reza-ebrahimi/transport_drivers
that referenced
this pull request
Mar 3, 2021
* serial: be specific about Boost dependency. * udp: be specific about Boost dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the spirit of Generating 'dev' and runtime artefacts from ROS packages on ROS Discourse this PR attempts to split the build and run dependencies for Boost for both the
serialandudppackages.CI will most likely fail until ros/rosdistro#23624 gets merged.
I've based the dependencies on what is
find_package(..)d in theCMakeLists.txt.