add prefix to nodelet name #28
Conversation
| @@ -8,7 +8,7 @@ | |||
| <arg name="ir" /> | |||
|
|
|||
| <!-- Rectified image --> | |||
| <node pkg="nodelet" type="nodelet" name="rectify_ir" | |||
| <node pkg="nodelet" type="nodelet" name="$(arg ir)_rectify_ir" | |||
There was a problem hiding this comment.
Is it safe to depend on an arg that is missing default value?
There was a problem hiding this comment.
@130s We already have launch file in which there are dependency on an arg in depth.launch.xml (https://github.com/ros-drivers/rgbd_launch/blob/indigo-devel/launch/includes/depth.launch.xml#L14).
If ir is not given, this launch file is invalid, and if ir is set to empty string, processed messages are published as global namespace and nodelet name will be _rectify_ir, which is also valid as ROS node name.(but I think it will be unusual name)
|
@furushchev Now that #29 is merged, would you be base and see how Travis goes? |
|
@130s Thanks. Rebased origin/indigo-devel. |
|
@130s Now test passed. Please merge if there is no problem. |
|
@furushchev could you rebase to the indigo-devel branch to pull in #31? |
|
@130s rebased origin/indigo-devel |
|
@130s Thank you for merging! |
Enable rostest Merge pull request ros-drivers#28 from furushchev/prefix add prefix to nodelet name
To work with robots with more than 2 rgb cameras, we have to avoid conflicts of each nodelet names.
In
depth.launch.xml,disparity.launch.xml, nodelet names are already defined with prefix, so I added prefix also torgb.launch.xmlsame as other include launch files.