Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Ruby 3.4.1 #937

Merged
merged 6 commits into from
Dec 27, 2024
Merged

Upgrade to Ruby 3.4.1 #937

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
99c18b5
Upgrade to Ruby 3.4.1
enzofab91 Dec 26, 2024
e888eaf
Fix
enzofab91 Dec 26, 2024
341ce4a
Fix gemfile.lock
enzofab91 Dec 26, 2024
64c32f6
Use ruby file for gemfile
enzofab91 Dec 26, 2024
c522962
Add .ruby-version file in docker container
enzofab91 Dec 26, 2024
d48e28b
Merge copy operations in a single one
enzofab91 Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ruby-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.3.5
3.4.1
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG RUBY_VERSION=3.3.5
ARG RUBY_VERSION=3.4.1
ARG NODE_VERSION=22.7.0

# Use Node image so we can pull the binaries from here.
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
ARG RUBY_VERSION=3.3.5
ARG RUBY_VERSION=3.4.1
ARG NODE_VERSION=22.7.0

# Use Node image so we can pull the binaries from here.
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

source 'https://rubygems.org'

ruby '~> 3.3.5'
ruby '~> 3.4.1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about
ruby file: '.ruby-version' ?

https://bundler.io/guides/gemfile_ruby.html
https://andycroll.com/ruby/read-ruby-version-in-your-gemfile/


gem 'rails', '~> 7.2.2'

Expand Down
14 changes: 1 addition & 13 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,8 +243,6 @@ GEM
faraday-retry (2.2.1)
faraday (~> 2.0)
ffi (1.17.0)
ffi (1.17.0-arm64-darwin)
ffi (1.17.0-x86_64-linux-gnu)
flipper (1.3.2)
concurrent-ruby (< 2)
flipper-active_record (1.3.2)
Expand All @@ -265,12 +263,6 @@ GEM
google-protobuf (4.29.2)
bigdecimal
rake (>= 13)
google-protobuf (4.29.2-arm64-darwin)
bigdecimal
rake (>= 13)
google-protobuf (4.29.2-x86_64-linux)
bigdecimal
rake (>= 13)
Comment on lines -268 to -273
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm strange that these gems for these platforms got removed 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is odd. I try to revert this changes but bundle install keeps doing it.

When it fails, on GH actions it says :

ffi-1.17.0-x86_64-linux-gnu requires ruby version < 3.4.dev, >= 2.5, which is
incompatible with the current version, 3.4.1

Maybe is no more needed? I couldn't find anything on google 😂

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 ok. Let's go ahead and if something breaks we can fix it

has_scope (0.8.2)
actionpack (>= 5.2)
activesupport (>= 5.2)
Expand Down Expand Up @@ -369,10 +361,6 @@ GEM
nokogiri (1.17.2)
mini_portile2 (~> 2.8.2)
racc (~> 1.4)
nokogiri (1.17.2-arm64-darwin)
racc (~> 1.4)
nokogiri (1.17.2-x86_64-linux)
racc (~> 1.4)
octokit (9.2.0)
faraday (>= 1, < 3)
sawyer (~> 0.9)
Expand Down Expand Up @@ -680,7 +668,7 @@ DEPENDENCIES
yaaf (~> 3.0)

RUBY VERSION
ruby 3.3.5p100
ruby 3.4.1p0

BUNDLED WITH
2.5.18
Loading