Upgrade to Ruby 3.4.1 #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santib
reviewed
Dec 26, 2024
Comment on lines
-268
to
-273
| google-protobuf (4.29.2-arm64-darwin) | ||
| bigdecimal | ||
| rake (>= 13) | ||
| google-protobuf (4.29.2-x86_64-linux) | ||
| bigdecimal | ||
| rake (>= 13) |
There was a problem hiding this comment.
hmmm strange that these gems for these platforms got removed 🤔
There was a problem hiding this comment.
This is odd. I try to revert this changes but bundle install keeps doing it.
When it fails, on GH actions it says :
ffi-1.17.0-x86_64-linux-gnu requires ruby version < 3.4.dev, >= 2.5, which is
incompatible with the current version, 3.4.1
Maybe is no more needed? I couldn't find anything on google 😂
There was a problem hiding this comment.
😮 ok. Let's go ahead and if something breaks we can fix it
santib
reviewed
Dec 26, 2024
Gemfile
Outdated
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| source 'https://rubygems.org' | |||
|
|
|||
| ruby '~> 3.3.5' | |||
| ruby '~> 3.4.1' | |||
There was a problem hiding this comment.
WDYT about
ruby file: '.ruby-version' ?
https://bundler.io/guides/gemfile_ruby.html
https://andycroll.com/ruby/read-ruby-version-in-your-gemfile/
JulianPasquale
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Board:
Description:
Upgrade to Ruby 3.4.1 released today.
Notes:
Tasks:
Risk:
Preview: