Add AWS CodeCommit Repo support.

[newloong]

Hey,

This pull request add AWS CodeCommit repo support.

Related: #969

Tested on:

macOS 10.13.3
ansible 2.4.3.0

[swalkinshaw]

I'm wondering if this check is even useful at this point. There's later connection test to make sure we can connect to the Git repo.

[fullyint]

@newloong Thanks for this. We discussed internally and agree we should enable the ssh:// form.

Background. I think #459 added the regexp validation to quickly warn users against the http(s):// format that often doesn't allow connection to private repos during later deploy tasks. I think #516 adjusted the regexp to ensure users had the : in their repo's git format (:x: git@github.com/roots/bedrock but ✅ git@github.com:roots/bedrock).

Your regexp. Could you revise your regexp to disallow the http(s) repo format? See proposed revision in example below. Does that regexp work for your CodeCommit repo?

Example revision. Maybe the fail msg could give the ssh:// format as an example too, e.g.,

    - name: Ensure repo is valid
      connection: local
      fail:
        msg: |
          Invalid Git repository format.
          Ensure that your site's `repo` variable is defined in
          `group_vars/{{ env }}/wordpress_sites.yml` and uses an SSH format.
          Examples:
            - git@github.com:roots/bedrock.git
            - ssh://git@github.com/roots/bedrock
          More info:
          > https://roots.io/trellis/docs/deploys/
      when: project.repo is not defined or not project.repo | match("(^ssh:|.+@.+:.+)")

[fullyint]

@newloong Thanks for the revised regexp. I like how you got rid of the unnecessary ( ) from my suggested example.

.git I should have mentioned it explicitly, but given that git clone git@github.com:roots/bedrock succeeds without the .git at the end, could you remove the regexp's requirement that repo values in \.git? I realize the original regexp in trellis had the .git so it made sense that you kept it.

slashes. Your pattern requires ssh:\/\/. I don't think it is necessary to escape the slashes. I don't think slashes are special/control characters in this context (a la https://docs.python.org/2/library/re.html#regular-expression-syntax) and aren't being used as pattern delimiters. Could you use the visually simpler ssh://?

.* vs .+ This last comment is trivial and you can ignore it if you want. I think each instance of .* truly needs "one or more" characters (.+); it would be an incorrect format if a user were to specify zero characters in any of those locations of the pattern, a la the "zero or more" of .*. Once again, I realize the original regexp used .*, but I think it'd be nice to get the extra accuracy given that it comes at no additional characters/cost.

summary. So, altogether I'm proposing:

- match("^ssh:\/\/.*@.*|.*@.*:.*\.git")
+ match("^ssh://.+@.+|.+@.+:.+")

Thanks again! Your help with this PR brings Trellis a good improvement.