Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add AWS CodeCommit Repo support #969

Closed
6 tasks done
newloong opened this issue Mar 22, 2018 · 3 comments
Closed
6 tasks done

Feature request: Add AWS CodeCommit Repo support #969

newloong opened this issue Mar 22, 2018 · 3 comments

Comments

@newloong
Copy link
Contributor

Submit a feature request or bug report


What is the current behavior?

No AWS CodeCommit Repo support

What is the expected or desired behavior?

Add AWS CodeCommit Repo support


Bug report

Please provide steps to reproduce, including full log output:

Got the following error using AWS CodeCommit as Repo(repo: ssh://git-codecommit.us-west-2.amazonaws.com/v1/repos/bedrock.example.com)

TASK [Ensure repo is valid]
System info:
Ansible 2.4.2.0; Darwin
Trellis at "Git: Ignore vagrant.local.yml"

Invalid Git repository.
Ensure that your site's repo variable is defined in
group_vars/staging/wordpress_sites.yml and uses the SSH format (example:
git@github.com:roots/bedrock.git)
More info:

https://roots.io/trellis/docs/deploys/

fatal: [staging_host]: FAILED! => {"changed": false}
to retry, use: --limit @/Users/name/sites/example.com/trellis/deploy.retry

PLAY RECAP
localhost : ok=0 changed=0 unreachable=0 failed=0
staging_host : ok=2 changed=0 unreachable=0 failed=1

Please describe your local environment:

Ansible version: 2.4.2.0

OS: macOS 10.13.3 (17D102)

Vagrant version: 2.0.2

Where did the bug happen? Development or remote servers?

Staging

Feature Request

Add AWS CodeCommit Repo support

@swalkinshaw
Copy link
Member

I'm assuming CodeCommit doesn't work if you append the .git extension?

@newloong
Copy link
Contributor Author

newloong commented Apr 1, 2018

@swalkinshaw Yes, it doesn't work, both append .git extension and without .git extension. The URI of CodeCommit repo like:
ssh://Your-SSH-Key-ID@git-codecommit.us-east-2.amazonaws.com/v1/repos/MyDemoRepo

So we need to improve the regular expressions, see #975

@fullyint
Copy link
Contributor

fullyint commented Apr 3, 2018

Closed in #975
Thanks @newloong!

@fullyint fullyint closed this as completed Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants