Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add friendly-errors-webpack-plugin #1961

Merged
merged 1 commit into from
Aug 23, 2017
Merged

Conversation

retlehs
Copy link
Member

@retlehs retlehs commented Aug 23, 2017

console errors were accidentally disabled, now they're back

ref https://discourse.roots.io/t/command-line-lint-errors-gone-in-beta-4/10227

@retlehs
Copy link
Member Author

retlehs commented Aug 23, 2017

hold up, now browsersync errors are suppressed. will followup

@QWp6t QWp6t merged commit c2a7b5e into master Aug 23, 2017
@QWp6t QWp6t deleted the friendly-errors-webpack-plugin branch August 23, 2017 16:51
@QWp6t
Copy link
Member

QWp6t commented Aug 23, 2017

I refuse to wait. merging anyway. YOLO

@MWDelaney
Copy link
Member

Stylelint's obnoxious "you didn't put a return in the right place" errors still seem to be suppressed, too. Makes it hard to figure out the "exit with error code 1" stuff.

oxyc added a commit to generoi/sage that referenced this pull request Sep 6, 2017
* 'genero' of github.com:generoi/sage: (28 commits)
  move options page defaults to bedrock
  fix phpcs
  some more woocommerce defaults
  better defaults
  move out code to separate repos
  Update config.json (roots#1963)
  Add friendly-errors-webpack-plugin (roots#1961)
  fix sql syntax error when post has no terms
  Move /controllers to app, remove app/lib/Sage in readme.
  Controller 9.0.0-beta.4
  Followup roots#1950: Fix lint:styles task with cmd.exe
  Change default Controller path to app/controllers
  Ensure to get templates filenames without path and extension.
  Fix lint:styles script not matching files in deep subdirectories
  Update helpers.php
  Update webpack.config.js (roots#1946)
  👀
  Bump sage-installer
  BS4 now requires Popper
  Bump sage-lib
  ...
ptrckvzn pushed a commit to ptrckvzn/sage that referenced this pull request Sep 13, 2017
* upstream/master: (45 commits)
  Remove get_the_posts_navigation from 404
  Update config.json (roots#1963)
  Add friendly-errors-webpack-plugin (roots#1961)
  Move /controllers to app, remove app/lib/Sage in readme.
  Controller 9.0.0-beta.4
  Followup roots#1950: Fix lint:styles task with cmd.exe
  Change default Controller path to app/controllers
  Ensure to get templates filenames without path and extension.
  Fix lint:styles script not matching files in deep subdirectories
  Update helpers.php
  Update webpack.config.js (roots#1946)
  👀
  Bump sage-installer
  BS4 now requires Popper
  Bump sage-lib
  Bootstrap 4 Beta, Sage 9.0.0-beta.4
  Remove PHP 5.6 tests from Travis
  Update README.md
  Update sage-installer 1.1 -> 1.2
  Update CHANGELOG
  ...

# Conflicts:
#	package.json
#	resources/assets/build/postcss.config.js
#	resources/assets/build/webpack.config.js
#	resources/assets/styles/common/_global.scss
#	resources/assets/styles/common/_variables.scss
#	resources/assets/styles/components/_comments.scss
#	resources/assets/styles/components/_forms.scss
#	resources/assets/styles/components/_wp-classes.scss
#	resources/assets/styles/layouts/_header.scss
#	resources/assets/styles/main.scss
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants