Fix Popper for Bootstrap 4 #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
6 tasks
oxyc
added a commit
to generoi/sage
that referenced
this pull request
Sep 6, 2017
* 'genero' of github.com:generoi/sage: (28 commits) move options page defaults to bedrock fix phpcs some more woocommerce defaults better defaults move out code to separate repos Update config.json (roots#1963) Add friendly-errors-webpack-plugin (roots#1961) fix sql syntax error when post has no terms Move /controllers to app, remove app/lib/Sage in readme. Controller 9.0.0-beta.4 Followup roots#1950: Fix lint:styles task with cmd.exe Change default Controller path to app/controllers Ensure to get templates filenames without path and extension. Fix lint:styles script not matching files in deep subdirectories Update helpers.php Update webpack.config.js (roots#1946) 👀 Bump sage-installer BS4 now requires Popper Bump sage-lib ...
ptrckvzn
pushed a commit
to ptrckvzn/sage
that referenced
this pull request
Sep 13, 2017
* upstream/master: (45 commits) Remove get_the_posts_navigation from 404 Update config.json (roots#1963) Add friendly-errors-webpack-plugin (roots#1961) Move /controllers to app, remove app/lib/Sage in readme. Controller 9.0.0-beta.4 Followup roots#1950: Fix lint:styles task with cmd.exe Change default Controller path to app/controllers Ensure to get templates filenames without path and extension. Fix lint:styles script not matching files in deep subdirectories Update helpers.php Update webpack.config.js (roots#1946) 👀 Bump sage-installer BS4 now requires Popper Bump sage-lib Bootstrap 4 Beta, Sage 9.0.0-beta.4 Remove PHP 5.6 tests from Travis Update README.md Update sage-installer 1.1 -> 1.2 Update CHANGELOG ... # Conflicts: # package.json # resources/assets/build/postcss.config.js # resources/assets/build/webpack.config.js # resources/assets/styles/common/_global.scss # resources/assets/styles/common/_variables.scss # resources/assets/styles/components/_comments.scss # resources/assets/styles/components/_forms.scss # resources/assets/styles/components/_wp-classes.scss # resources/assets/styles/layouts/_header.scss # resources/assets/styles/main.scss # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to #1945, I figured out what was wrong. Bootstrap's dropdown documentation indicates the "umd" version of Popper (poorly; you have to look at the actual URL they link to) which fixes the issue of dropdowns not working in Sage Beta 4.