Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nbconvert version specifier in requirements.txt #984

Closed
wants to merge 1 commit into from

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented Jul 20, 2023

A comma is interpreted as a logical AND and naturally there exists no version that satisfies the requirement < 7.3 , >= 7.4. Change it to exclude 7.3.*.

A comma is interpreted as a logical AND and naturally there exists
no version that satisfies the requirement "< 7.3 , >= 7.4". Change
it to exclude 7.3.*.
@hahnjo hahnjo requested a review from vepadulano July 20, 2023 11:16
@hahnjo hahnjo self-assigned this Jul 20, 2023
@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac11/noimt, mac12arm/cxx20, windows10/cxx14
How to customize builds

@vepadulano
Copy link
Member

Thank you Jonas! See #983 , I agree this it the right fix, we can merge either PR

@hahnjo hahnjo closed this Jul 20, 2023
@hahnjo hahnjo deleted the requirements-nbconvert branch July 20, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants