[ci] Specify nbconvert version in requirements.txt #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent failures of roottest-python-JupyROOT-importROOT_notebook
(specifically on Fedora 37) would report the message
```
[NbConvertApp] Converting notebook importROOT.ipynb to notebook
[NbConvertApp] Writing 988 bytes to importROOT_out.nbconvert.ipynb
...
File "/tmp/workspace/src/roottest/python/JupyROOT/nbdiff.py", line 68, in getFilteredLines
filteredLines = list(filter(customLineJunkFilter, open(fileName).readlines()))
^^^^^^^^^^^^^^
FileNotFoundError: [Errno 2] No such file or directory: 'importROOT_out.ipynb'
```
This is due to a bug in nbconvert version 7.3, as described in
jupyter/nbconvert#1970. Other versions of the
package do not suffer from the bug, so we update the requirements.txt
file accordingly.
|
Starting build on |
pcanal
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent failures of roottest-python-JupyROOT-importROOT_notebook (specifically on Fedora 37) would report the message
This is due to a bug in nbconvert version 7.3, as described in jupyter/nbconvert#1970. Other versions of the package do not suffer from the bug, so we update the requirements.txt file accordingly.