Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webgui] improve chrome handling, enable stressgraphics-chrome again #16691

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

linev
Copy link
Member

@linev linev commented Oct 15, 2024

It is adjusting chrome on top of #16685

Testing chrome and firefox stressgraphics.

Copy link

github-actions bot commented Oct 15, 2024

Test Results

    17 files      17 suites   3d 14h 39m 23s ⏱️
 2 713 tests  2 713 ✅ 0 💤 0 ❌
43 511 runs  43 511 ✅ 0 💤 0 ❌

Results for commit 0305f42.

♻️ This comment has been updated with latest results.

linev added 5 commits October 16, 2024 09:48
Mac requires webgpu enabled to be able use 3D graphics in batch mode
Also move dump-dom argument to command line settings
Keep --no-sandbox while it requires by super-user
May affect tests like webgui-ping
Most changes are variation in PDF file sizes
3D testing is disables
For testing purposes only
Try to run stressGraphics with firefox, but without 3d

On several platforms (like Windows and sometime Mac) firefox
has problem to initialize WebGL and fallback solution does not work
properly
@linev linev changed the title [webgui] adjust chrome handling [DRAFT!] [webgui] improve chrome handling, enable stressgraphics-chrome again Oct 16, 2024
Copy link
Member

@bellenot bellenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But let's see what @dpiparo think

@linev linev merged commit b70d85a into root-project:master Oct 16, 2024
19 of 21 checks passed
@linev linev deleted the chrome_fixes branch October 16, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants