-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[webgui] support Safari, improve headless modes, disable stressgraphics-chrome
#16685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While safari does not accept command-line args, just use `open -a Safari $url` command. Works only in interactive mode, headless operations does not supported
On mac platform headless firefox does not ends gracefully Therefore via runfirefox.sh script terminate it when finishing message appears in output. Use same script on the Linux to test functionality
Few bigger variations in PNG and JPEG
linev
force-pushed
the
web_mac_support
branch
from
October 15, 2024 10:45
de6cea8
to
9f38b67
Compare
Test Results 17 files 17 suites 3d 23h 37m 9s ⏱️ For more details on these failures, see this check. Results for commit 8c63100. ♻️ This comment has been updated with latest results. |
This is when webgui/ping/pnig.cxx tests running in batch mode. Like in pure batch mode, one can run firefox from shell script to be able redirect error output. Keep for the moment "fork:" which let us control shutdown of the browser
For the moment cannot reproduce problem on fedora39
linev
force-pushed
the
web_mac_support
branch
from
October 15, 2024 14:44
6bf6659
to
8c63100
Compare
linev
changed the title
[webgui] support Safari, improve headless modes
[webgui] support Safari, improve headless modes, disable Oct 15, 2024
stressgraphics-chrome
bellenot
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
firefox
viarunfirefox.sh
script (Linux/Mac), let stopfirefox
in batch mode on MacstressGraphics_web.ref
file to match Mac/Chrome, Mac/Firefox, Windows/Firefox