Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webgui] support Safari, improve headless modes, disable stressgraphics-chrome #16685

Merged
merged 8 commits into from
Oct 16, 2024

Conversation

linev
Copy link
Member

@linev linev commented Oct 15, 2024

  1. Support Safari, only can be used in interactive mode
  2. Always run firefox via runfirefox.sh script (Linux/Mac), let stop firefox in batch mode on Mac
  3. Enable webgpu usage for chrome, requires on Mac to support 3d graphics
  4. Adjust stressGraphics_web.ref file to match Mac/Chrome, Mac/Firefox, Windows/Firefox

While safari does not accept command-line args,
just use `open -a Safari $url` command.
Works only in interactive mode, headless operations does not supported
On mac platform headless firefox does not ends gracefully
Therefore via runfirefox.sh script terminate it
when finishing message appears in output.
Use same script on the Linux to test functionality
Few bigger variations in PNG and JPEG
Copy link

github-actions bot commented Oct 15, 2024

Test Results

    17 files      17 suites   3d 23h 37m 9s ⏱️
 2 712 tests  2 711 ✅ 0 💤 1 ❌
43 509 runs  43 508 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 8c63100.

♻️ This comment has been updated with latest results.

This is when webgui/ping/pnig.cxx tests running in batch mode.
Like in pure batch mode, one can run firefox from shell script
to be able redirect error output.

Keep for the moment "fork:" which let us control shutdown of the browser
For the moment cannot reproduce problem on fedora39
@linev linev changed the title [webgui] support Safari, improve headless modes [webgui] support Safari, improve headless modes, disable stressgraphics-chrome Oct 15, 2024
@linev linev merged commit 2f7462f into root-project:master Oct 16, 2024
17 of 20 checks passed
@linev linev deleted the web_mac_support branch October 16, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants