Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean: removing all the content related to bash #127

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

subhamkrai
Copy link
Collaborator

clean: removing all the content related to bash

removing bash script for tool and also removing the CI's
which are not useful anymore since we are moving to go.

Signed-off-by: subhamkrai srai@redhat.com

nit: this commits cleans the go-related codes.

this commits clean the code like,

  1. removing the unused var
  2. formating the imports

Signed-off-by: subhamkrai srai@redhat.com

removing bash script for tool and also removing the CI's
which are not useful anymore since we are moving to go.

Signed-off-by: subhamkrai <srai@redhat.com>
this commits clean the code like,
1. removing the unused var
2. formating the imports

Signed-off-by: subhamkrai <srai@redhat.com>
Copy link
Member

@travisn travisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a happy or sad day when the bash script goes away? :)

@subhamkrai
Copy link
Collaborator Author

Is it a happy or sad day when the bash script goes away? :)

I'll say I'm happy mostly but always sad to remove the code that we write.

@subhamkrai subhamkrai merged commit fa3a9f3 into rook:master Jun 16, 2023
@subhamkrai subhamkrai deleted the remove-bash-content branch June 16, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants