Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending task for new process of releasing with golang migration #125

Closed
4 tasks done
subhamkrai opened this issue Jun 16, 2023 · 9 comments
Closed
4 tasks done

Pending task for new process of releasing with golang migration #125

subhamkrai opened this issue Jun 16, 2023 · 9 comments
Assignees

Comments

@subhamkrai
Copy link
Collaborator

subhamkrai commented Jun 16, 2023

These are steps we need to do for releasing with go

@subhamkrai subhamkrai self-assigned this Jun 16, 2023
@subhamkrai
Copy link
Collaborator Author

@travisn I created the issue so that we are all on the same page regarding adding the changes for the new release

@subhamkrai subhamkrai changed the title New process of releasing with golang migration Pending task for new process of releasing with golang migration Jun 16, 2023
@travisn
Copy link
Member

travisn commented Jun 16, 2023

When someone upgrades the krew plugin, will the bash script be automatically removed? Or is there any manual cleanup?

@subhamkrai
Copy link
Collaborator Author

When someone upgrades the krew plugin, will the bash script be automatically removed? Or is there any manual cleanup?

I assumption is krew should handle that automatically.

@travisn
Copy link
Member

travisn commented Jun 16, 2023

When someone upgrades the krew plugin, will the bash script be automatically removed? Or is there any manual cleanup?

I assumption is krew should handle that automatically.

Is there a way to test the new release before it's officially out? Then we can confirm that the upgrade is smooth for the transition.

@travisn
Copy link
Member

travisn commented Jun 16, 2023

btw let's wait until early next week for the release so we don't have a release just before the weekend

@subhamkrai
Copy link
Collaborator Author

btw let's wait until early next week for the release so we don't have a release just before the weekend

Yes, I have a few testing with migration to do I have found this https://krew.sigs.k8s.io/docs/developer-guide/testing-locally/ to test locally exploring how we can test this.

@subhamkrai
Copy link
Collaborator Author

also holding this pr #128 till above testing is done

@subhamkrai
Copy link
Collaborator Author

btw let's wait until early next week for the release so we don't have a release just before the weekend

Yes, I have a few testing with migration to do I have found this https://krew.sigs.k8s.io/docs/developer-guide/testing-locally/ to test locally exploring how we can test this.

I did manual testing it was working but the testing process is not the same as the one we have in CI, since ci is full automation and one ci depends on another CI. We can follow up offline

@subhamkrai
Copy link
Collaborator Author

All task is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants