This repository has been archived by the owner on Aug 4, 2021. It is now read-only.
Support browser path false for require without ext #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's pretty common for node modules to use require() without specifying the file extension, so adding this will most likely make a few more libraries work with rollup. One project doing this is for instance `object-assign` which doesn't work currently. inspect-js/object-inspect#18 Considering the line that checks for changed paths below does exactly the same it's probably just an oversight that this was missing.
porsager
changed the title
porsager
changed the title
porsager
changed the title
lukastaegert
suggested changes
Apr 5, 2019
bhousel
added a commit
to openstreetmap/iD
that referenced
this pull request
Sep 5, 2019
|
Closing as abandoned. We're getting ready to move this plugin to https://github.com/rollup/plugins and would welcome a new PR there for review once the move is complete. 🍺 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's pretty common for node modules to use require() without specifying the file extension, so adding this will most likely make a few more libraries work with rollup. One project doing this is for instance
object-assignwhich doesn't work currently. inspect-js/object-inspect#18Considering the line that checks for changed paths below does exactly the same it's probably just an oversight that this was missing.