-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser bundling regression #18
Comments
That commit explicitly added a browser entry point with the "browser" field in package.json. Does rollup not support that community standard? Browserify and webpack don't seem to have trouble with it (I tested that explicitly prior to publishing). |
I'm going to close this; please file an issue on rollup if it can't handle the "browser" field and link it here! |
Sorry for the late answer @ljharb .. Seems like there's finally a PR to add support on rollup here. rollup/rollup-plugin-node-resolve#183 |
It's pretty common for node modules to use require() without specifying the file extension, so adding this will most likely make a few more libraries work with rollup. One project doing this is for instance `object-assign` which doesn't work currently. inspect-js/object-inspect#18 Considering the line that checks for changed paths below does exactly the same it's probably just an oversight that this was missing.
Bundling object-inspect with rollup doesn't work and will throw errors because it thinks the package relies on node's
util
module.and there
Relevant commit where the change was made.
20cca77
The text was updated successfully, but these errors were encountered: