Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portfolio Page - Hong Yun #70

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Portfolio Page - Hong Yun #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
955f103
added nav bar & center banner
magiicloud Oct 3, 2023
4bd17e9
added font monteserat and hind
magiicloud Oct 3, 2023
3fdc344
added flexbox to navbar and banner and added meta for screen width
magiicloud Oct 3, 2023
5309fda
added filler space in navbar and left logo. also reset the default cs…
magiicloud Oct 3, 2023
8bcc4b8
split the banner and about
magiicloud Oct 3, 2023
4f5f9fb
added projects css and html
magiicloud Oct 3, 2023
93b38d1
added image placeholder for projects and remove center alignment for …
magiicloud Oct 3, 2023
a3bfba7
added contact section html and css
magiicloud Oct 3, 2023
b757273
changed contact class to footer
magiicloud Oct 4, 2023
d6d4df0
fixed nav bar
magiicloud Oct 4, 2023
59d8269
changed title and added comments to KIV change icons
magiicloud Oct 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added Humaaans.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
76 changes: 73 additions & 3 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,83 @@
<!DOCTYPE html>
<html lang="en">
<meta name="viewport" content="width=device-width, initial-scale=1" />
<head>
<meta charset="utf-8" />

<link rel="preconnect" href="https://fonts.googleapis.com" />
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin />
<link
href="https://fonts.googleapis.com/css2?family=Hind:wght@300;400;700&family=Montserrat:wght@300;400;700&display=swap"
rel="stylesheet"
/>
<link href="styles.css" rel="stylesheet" />

<title>Rocket Academy</title>
<title>Hello, I'm Hong Yun</title>
</head>
<body>
<h1>Hello, world!</h1>
<!-- Nav Bar -->
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment is somewhat redundant, as the nav tag and the class already tell you what it is

<nav class="nav-bar">
<div><h3>HY</h3></div>
<div class="nav-bar-filler"></div>

<!-- KIV Change to social icons with links, more intuitive flow -->
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does KIV mean? If you use acronyms in code, you need to make sure everyone understands

<div>Home</div>
<div>About</div>
<div>Portfolio</div>
<div>Contact</div>
</nav>

<!-- Center Banner -->
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as with nav, somewhat redundant

<header class="banner">
<div><h2>HONG YUN</h2></div>
</header>
<section class="about">
Hey there, I'm really excited to show you the projects I've been working
on!
</section>

<!-- Projects -->
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

<section class="projects">
<div>
<a href="#" target="_blank">
<img src="./Humaaans.png" alt="Project 1 Image" style="width: 250px"
/></a>
</div>
<div>
<h2>Project 1 Header</h2>
<div class="project-text">Test Description</div>
</div>
</section>

<section class="projects">
<div>
<h2>Project 2 Header</h2>
<div class="project-text">Test Description</div>
</div>
<div>
<a href="#" target="_blank">
<img src="./Humaaans.png" alt="Project 2 Image" style="width: 250px"
/></a>
</div>
</section>

<section class="projects">
<div>
<a href="#" target="_blank">
<img src="./Humaaans.png" alt="Project 3 Image" style="width: 250px"
/></a>
</div>
<div>
<h2>Project 3 Header</h2>
<div class="project-text">Test Description</div>
</div>
</section>

<footer class="contact" id="footer">
<div><h2>Let's connect</h2></div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

H2 is a block element already, why use the div?

<div class="contact-info">
<div>GitHub</div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could use something else than a div here

<div>IG</div>
</div>
</footer>
</body>
</html>
88 changes: 87 additions & 1 deletion styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,89 @@
* {
margin: 0;
padding: 0;
}

.nav-bar {
font-family: "Hind", sans-serif;
display: flex;
flex-direction: row;
margin: 10px;
justify-content: flex-end;
font-size: 14px;
position: fixed;
top: 0;
width: 98%;
}

.nav-bar > div {
margin: 8px;
text-align: center;
}

.nav-bar-filler {
display: flex;
flex-grow: 1;
}

body {
background-color: white;
background-color: #dfe0dc;
}

.banner {
font-family: "Montserrat", sans-serif;
font-size: 18px;
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
height: 100px;
margin: 80px 20px 20px 20px;
}

.about {
font-family: "Hind", sans-serif;
font-size: 16px;
display: flex;
flex-direction: column;
align-items: center;
margin: 20px;
height: 200px;
}

.projects {
font-family: "Montserrat", sans-serif;
font-size: 14px;
display: flex;
flex-direction: row;
justify-content: space-around;
height: 350px;
}
.projects > div {
margin: 30px;
height: 250px;
width: 250px;
}

.project-text {
font-family: "Hind", sans-serif;
font-size: 16px;
padding-top: 5px;
}

.contact {
background-color: #b0b6bc;
font-family: "Montserrat", sans-serif;
font-size: 14px;
display: flex;
flex-direction: column;
align-items: center;
height: 150px;
margin-top: 50px;
padding: 20px 20px 20px 20px;
}
.contact-info {
display: flex;
flex-direction: row;
justify-content: center;
margin: 40px 10px 10px 10px;
}