Portfolio Page - Hong Yun #70
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…project so that it align top
Flashrob
reviewed
Oct 9, 2023
| </head> | ||
| <body> | ||
| <h1>Hello, world!</h1> | ||
| <!-- Nav Bar --> |
There was a problem hiding this comment.
The comment is somewhat redundant, as the nav tag and the class already tell you what it is
| <div><h3>HY</h3></div> | ||
| <div class="nav-bar-filler"></div> | ||
|
|
||
| <!-- KIV Change to social icons with links, more intuitive flow --> |
There was a problem hiding this comment.
What does KIV mean? If you use acronyms in code, you need to make sure everyone understands
| <div>Contact</div> | ||
| </nav> | ||
|
|
||
| <!-- Center Banner --> |
| on! | ||
| </section> | ||
|
|
||
| <!-- Projects --> |
| </section> | ||
|
|
||
| <footer class="contact" id="footer"> | ||
| <div><h2>Let's connect</h2></div> |
There was a problem hiding this comment.
H2 is a block element already, why use the div?
| <footer class="contact" id="footer"> | ||
| <div><h2>Let's connect</h2></div> | ||
| <div class="contact-info"> | ||
| <div>GitHub</div> |
There was a problem hiding this comment.
I think we could use something else than a div here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.