Fix find_path call to search for IPOPT_INCLUDE_DIRS #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattacini
approved these changes
Mar 22, 2020
drdanz
approved these changes
Mar 25, 2020
|
Merged, thanks. |
traversaro
added a commit
to robotology/idyntree
that referenced
this pull request
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using a recent CMake (3.17) on Windows, and for IPOPT_INCLUDE_DIRS the
FindIPOPT.cmakescript was finding the wrong pathC:/robotology/vcpkg/installed/x64-windows/include/coininstead of the correctC:/robotology/vcpkg/installed/x64-windows/include. Note that all uses of IPOPT headers, even in their examples (see https://github.com/coin-or/Ipopt/blob/releases/3.13.1/examples/Cpp_example/MyNLP.hpp) use the direct inclusion of the headers (i.e.#include <IpTNLP.hpp>, not#include <coin/IpTNLP.hpp>.With this fix, the
FindIPOPT.cmakeshould never find the wrong include path for IPOPT. To be honest, I do not know why it we never noticed this problem, it is possible that something subtle changed at the CMake level in CMake 3.17).