Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/viz viewports #903

Merged
merged 9 commits into from
Jul 28, 2021
Merged

Conversation

S-Dafarra
Copy link
Contributor

@S-Dafarra S-Dafarra commented Jul 21, 2021

  • Fixed the conversion from irrlicht pixels to iDynTree pixels.
  • Fixed a typo in the environment method of the visualizer.
  • Fixed the running of two visualizer instances in the same process
  • Added the possibility to draw in different portions of the visualizer window and textures at the same time.
  • Added the possibility to draw textures on file.
  • Allow disabling the drawing on textures.
  • Fixed the visualization of labels when they should be hidden.

@S-Dafarra S-Dafarra marked this pull request as draft July 21, 2021 11:26
@S-Dafarra S-Dafarra force-pushed the feature/viz_viewports branch from 15dfa5b to 27e7476 Compare July 21, 2021 15:48
- Added the possibility to get the sizes of the window.
- Added the possibility to disable the drawing on some textures. This would allow drawing the output of two different cameras positions on two different textures.
- Fixed the conversion from irrlicht to iDyntree pixels when getting the pixels from a texture.
- Fixed the return value logic of drawToFile.
@S-Dafarra S-Dafarra force-pushed the feature/viz_viewports branch from 2daf3a2 to 4491959 Compare July 23, 2021 09:52
@S-Dafarra S-Dafarra requested a review from traversaro July 26, 2021 12:38
@S-Dafarra S-Dafarra self-assigned this Jul 26, 2021
@S-Dafarra S-Dafarra marked this pull request as ready for review July 26, 2021 12:38
@S-Dafarra
Copy link
Contributor Author

Related PR to consider the change in the pixel format robotology/idyntree-yarp-tools#16

@S-Dafarra
Copy link
Contributor Author

From the code point of view, I think this is ready to be merged

@traversaro traversaro merged commit a2b6936 into robotology:devel Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants