-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/viz viewports #903
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
S-Dafarra
commented
Jul 21, 2021
•
edited
Loading
edited
- Fixed the conversion from irrlicht pixels to iDynTree pixels.
- Fixed a typo in the environment method of the visualizer.
- Fixed the running of two visualizer instances in the same process
- Added the possibility to draw in different portions of the visualizer window and textures at the same time.
- Added the possibility to draw textures on file.
- Allow disabling the drawing on textures.
- Fixed the visualization of labels when they should be hidden.
S-Dafarra
force-pushed
the
feature/viz_viewports
branch
from
July 21, 2021 15:48
15dfa5b
to
27e7476
Compare
- Added the possibility to get the sizes of the window. - Added the possibility to disable the drawing on some textures. This would allow drawing the output of two different cameras positions on two different textures. - Fixed the conversion from irrlicht to iDyntree pixels when getting the pixels from a texture. - Fixed the return value logic of drawToFile.
…re drawing to a texture.
S-Dafarra
force-pushed
the
feature/viz_viewports
branch
from
July 23, 2021 09:52
2daf3a2
to
4491959
Compare
traversaro
approved these changes
Jul 26, 2021
Related PR to consider the change in the pixel format robotology/idyntree-yarp-tools#16 |
From the code point of view, I think this is ready to be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.