Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting iDynTree (float) pixels to yarp (unsigned char). #16

Merged
merged 3 commits into from
Jul 28, 2021
Merged

Converting iDynTree (float) pixels to yarp (unsigned char). #16

merged 3 commits into from
Jul 28, 2021

Conversation

S-Dafarra
Copy link
Collaborator

Fixed some deprecation warnings.

Related to robotology/idyntree#903

@S-Dafarra S-Dafarra mentioned this pull request Jul 26, 2021
Merged
@traversaro
Copy link
Member

Can you bump version to 0.0.2 ?

@traversaro
Copy link
Member

At least until iDynTree 5 is released, we may need to swith to compile iDynTree from source, see https://github.com/robotology/yarp-matlab-bindings/blob/master/.github/workflows/conda-ci.yml for a similar case (in that case YARP is compiled from source).

@S-Dafarra
Copy link
Collaborator Author

S-Dafarra commented Jul 26, 2021 •
edited
Loading

At least until iDynTree 5 is released, we may need to swith to compile iDynTree from source, see https://github.com/robotology/yarp-matlab-bindings/blob/master/.github/workflows/conda-ci.yml for a similar case (in that case YARP is compiled from source).

I created the branch devel with the initial idea of keeping there the code that is related to unreleased versions of yarp/iDynTree. On the other hand, I did not consider that the CI would have failed. It would be interesting having the CI automatically picking the development version (devel for iDynTree, master for yarp) for the code that is in the devel branch 🤔

@traversaro
Copy link
Member

At least until iDynTree 5 is released, we may need to swith to compile iDynTree from source, see https://github.com/robotology/yarp-matlab-bindings/blob/master/.github/workflows/conda-ci.yml for a similar case (in that case YARP is compiled from source).

I created the branch devel with the initial idea of keeping there the code that is related to unreleased versions of yarp/iDynTree. On the other hand, I did not consider that the CI would have failed. It would be interesting having the CI automatically picking the development version (devel for iDynTree, master for yarp) for the code that is in the devel branch 🤔

You can check the base branch of the PR, but for the time being just switching to compile from source I think it is ok.

@S-Dafarra
Copy link
Collaborator Author

You can check the base branch of the PR, but for the time being just switching to compile from source I think it is ok.

Done in #17.

@S-Dafarra S-Dafarra requested a review from traversaro July 28, 2021 16:17
@S-Dafarra S-Dafarra marked this pull request as ready for review July 28, 2021 16:17
@traversaro traversaro merged commit eac8536 into devel Jul 28, 2021
@S-Dafarra S-Dafarra deleted the fixPixelFormat branch July 30, 2021 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@S-Dafarra @traversaro